Add ARC app icons to the Task Manager UI

chrome/browser/task_management/providers/arc/arc_process_task.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/task_management/providers/arc/arc_process_task.h"
 
+#include "base/bind.h"
 #include "base/i18n/rtl.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/grit/generated_resources.h"
 #include "components/arc/arc_bridge_service.h"
+#include "components/arc/arc_service_manager.h"
 #include "components/arc/common/process.mojom.h"
+#include "content/public/browser/browser_thread.h"
 #include "content/public/common/child_process_host.h"
 #include "ui/base/l10n/l10n_util.h"
 
 namespace task_management {
 
 namespace {
 
 base::string16 MakeTitle(const std::string& process_name) {
   base::string16 title =
       l10n_util::GetStringFUTF16(
           IDS_TASK_MANAGER_ARC_PREFIX, base::UTF8ToUTF16(process_name));
   base::i18n::AdjustStringForLocaleDirection(&title);
   return title;
 }
 
+scoped_refptr<arc::ActivityIconLoader> GetIconLoader() {
+  DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
+  arc::ArcServiceManager* arc_service_manager = arc::ArcServiceManager::Get();
+  if (!arc_service_manager)
+    return nullptr;
+  return arc_service_manager->icon_loader();
+}
+
+// An activity name for retrieving the package's default icon without
+// specifying an activity name.
+const char kEmptyActivityName[] = "";
+
 }  // namespace
 
-ArcProcessTask::ArcProcessTask(
-    base::ProcessId pid,
-    base::ProcessId nspid,
-    const std::string& process_name,
-    arc::mojom::ProcessState process_state)
-    : Task(MakeTitle(process_name), process_name, nullptr, pid),
+ArcProcessTask::ArcProcessTask(base::ProcessId pid,
+                               base::ProcessId nspid,
+                               const std::string& process_name,
+                               arc::mojom::ProcessState process_state,
+                               const std::vector<std::string>& packages)
+    : Task(MakeTitle(process_name), process_name, nullptr /* icon */, pid),
       nspid_(nspid),
       process_name_(process_name),
-      process_state_(process_state) {
+      process_state_(process_state),
+      weak_factory_(this) {
+  DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
+  if (packages.empty())
+    return;
+
+  std::vector<arc::ActivityIconLoader::ActivityName> activity;
+  // |packages| contains an alphabetically-sorted list of package names the
+  // process has. Since the Task class can hold only one icon per process,
+  // and there is no reliable way to pick the most important process from
+  // the |packages| list, just use the first item in the list.
+  activity.emplace_back(packages.at(0), kEmptyActivityName);
+
+  scoped_refptr<arc::ActivityIconLoader> icon_loader = GetIconLoader();
+  if (!icon_loader)
+    return;
+
+  // TODO(yusukes): ArcProcessTask might be created before intent_helper
+  // instance becomes ready. Because of the race, OnIconLoaded() might
+  // be called synchronously with no icon. Fix the race to ensure that
+  // ArcProcessTask can always fetch icons.
+  icon_loader->GetActivityIcons(
+      activity,
+      base::Bind(&ArcProcessTask::OnIconLoaded, weak_factory_.GetWeakPtr()));
 }
 
 ArcProcessTask::~ArcProcessTask() {
 }
 
 Task::Type ArcProcessTask::GetType() const {
   return Task::ARC;
 }
 
 int ArcProcessTask::GetChildProcessUniqueID() const {
@@ skipping 18 matching lines @@
     return;
   }
   arc_process_instance->KillProcess(
       nspid_, "Killed manually from Task Manager");
 }
 
 void ArcProcessTask::SetProcessState(arc::mojom::ProcessState process_state) {
   process_state_ = process_state;
 }
 
+void ArcProcessTask::OnIconLoaded(
+    std::unique_ptr<arc::ActivityIconLoader::ActivityToIconsMap> icons) {
+  DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
+  for (const auto& kv : *icons) {
+    const gfx::Image& icon = kv.second.icon16;
+    if (icon.IsEmpty())
+      continue;
+    icon_ = icon;

[afakhry, 2016/06/01 17:07:14]

Is there a reason to store gfx::Image as a member here while the parent class
stores gfx::ImageSkia? Now we have two members named |icon_| (Task::icon_ and
ArcProcessTask::icon_)!

If not needed, please remove that extra |icon_| member here, and just do
set_icon(*icon_.ToImageSkia()); 
I think the ImageSkia& operator=(const ImageSkia& other); (used in set_icon())
will AddRef() the ImageSkiaStorage member of the ImageSkia object, and it should
work fine.

[Yusuke Sato, 2016/06/01 19:11:29]

I read the code again, and you're right. Removed the icon_ member from this
class. Done.

+    set_icon(*icon_.ToImageSkia());  // Pass a weak pointer of the |icon_|.
+    break;  // Since the parent class can hold only one icon, break here.
+  }
+}
+
 }  // namespace task_management