Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: blimp/client/feature/ime_feature.h

Issue 2023613002: Add a FakeImeFeatureDelegate to the Linux client. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments & fix private: placement Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/client/app/linux/blimp_client_session_linux.cc ('k') | blimp/client/feature/navigation_feature.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/client/feature/ime_feature.h
diff --git a/blimp/client/feature/ime_feature.h b/blimp/client/feature/ime_feature.h
index a61ba2bf6c35d73173046c5ac0730529fe47089a..7de0ee08e83c3b95580a71ae588f10724cb3941c 100644
--- a/blimp/client/feature/ime_feature.h
+++ b/blimp/client/feature/ime_feature.h
@@ -50,19 +50,19 @@ class ImeFeature : public BlimpMessageProcessor {
}
// Sets a Delegate to be notified of all text input messages.
- // Passing a null |delegate| causes IME messages to be ignored.
+ // There must be a valid non-null Delegate set before routing messages
+ // to the ImeFeature for processing, until the last message is processed.
void set_delegate(Delegate* delegate) { delegate_ = delegate; }
// Sends text from IME to the blimp engine.
void OnImeTextEntered(const std::string& text);
- private:
// BlimpMessageProcessor implementation.
void ProcessMessage(std::unique_ptr<BlimpMessage> message,
const net::CompletionCallback& callback) override;
- // Delegate for processing the text input related messages. |delegate_| must
- // remain valid until the last message has been passed to ImeFeature.
+ private:
+ // Used to actually show or hide the IME. See notes on |set_delegate|.
Delegate* delegate_ = nullptr;
// Tab id and render widget id for the input field for which user input is
« no previous file with comments | « blimp/client/app/linux/blimp_client_session_linux.cc ('k') | blimp/client/feature/navigation_feature.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698