Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h

Issue 2023603003: Fix content scripts that use WebGL. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@yukishiino-v8privateproperty-fix
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h b/third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h
index 607123e9f1899c5327f4e0320f69e30a44a67982..24f9266891ff2f299f4e3cceeb2d683faf3293c9 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h
+++ b/third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h
@@ -22,7 +22,18 @@ class ScriptWrappable;
// Apply |X| for each pair of (InterfaceName, PrivateKeyName).
#define V8_PRIVATE_PROPERTY_FOR_EACH(X) \
- X(MessageEvent, CachedData)
+ X(MessageEvent, CachedData) \
+ X(WebGLRenderingContext, Extensions) \
+ X(WebGLRenderingContext, Misc) \
+ X(WebGLRenderingContext, Queries) \
+ X(WebGLRenderingContext, Samplers) \
+ X(WebGLRenderingContext, Textures2D) \
+ X(WebGLRenderingContext, Textures2DArray) \
+ X(WebGLRenderingContext, Textures3D) \
+ X(WebGLRenderingContext, TexturesCubeMap) \
+ X(WebGLFramebuffer, Attachments) \
+ X(WebGLProgram, Shaders) \
+ X(WebGLVertexArrayObjectBase, Buffers)
// The getter's name for a private property.
#define V8_PRIVATE_PROPERTY_GETTER_NAME(InterfaceName, PrivateKeyName) \
@@ -62,7 +73,7 @@ public:
class CORE_EXPORT Symbol {
STACK_ALLOCATED();
public:
- v8::Local<v8::Value> get(v8::Local<v8::Context> context, v8::Local<v8::Object> object)
+ v8::Local<v8::Value> get(v8::Local<v8::Context> context, v8::Local<v8::Object> object) const
{
if (!v8CallBoolean(object->HasPrivate(context, m_privateSymbol)))
return v8::Local<v8::Value>();
@@ -72,7 +83,7 @@ public:
return v8::Local<v8::Value>();
}
- bool set(v8::Local<v8::Context> context, v8::Local<v8::Object> object, v8::Local<v8::Value> value)
+ bool set(v8::Local<v8::Context> context, v8::Local<v8::Object> object, v8::Local<v8::Value> value) const
{
return v8CallBoolean(object->SetPrivate(context, m_privateSymbol, value));
}

Powered by Google App Engine
This is Rietveld 408576698