Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTableRow.cpp

Issue 2023583002: [css-tables] Set ancestor widths dirty when row border width changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove extra id Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/table/change-row-border-width-floating-container-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutTableRow.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp b/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp
index cc800331100f484e9f021dd638b8e549bd1c5241..9fd494408f0514348a4bfcf40a6429e57452141e 100644
--- a/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp
@@ -81,13 +81,19 @@ void LayoutTableRow::styleDidChange(StyleDifference diff, const ComputedStyle* o
// If the border width changes on a row, we need to make sure the cells in the row know to lay out again.
// This only happens when borders are collapsed, since they end up affecting the border sides of the cell
// itself.
- table->setPreferredLogicalWidthsDirty(MarkOnlyThis);
for (LayoutBox* childBox = firstChildBox(); childBox; childBox = childBox->nextSiblingBox()) {
if (!childBox->isTableCell())
continue;
childBox->setChildNeedsLayout();
childBox->setPreferredLogicalWidthsDirty(MarkOnlyThis);
}
+ // Most table componenents can rely on LayoutObject::styleDidChange
+ // to mark the container chain dirty. But LayoutTableSection seems
+ // to never clear its dirty bit, which stops the propagation. So
+ // anything under LayoutTableSection has to restart the propagation
+ // at the table.
+ // TODO(dgrogan): Make LayoutTableSection clear its dirty bit.
+ table->setPreferredLogicalWidthsDirty();
}
}
}
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/table/change-row-border-width-floating-container-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698