Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2023573002:
Add mip support to *DeferredTextureImageData functions. (Closed)
DescriptionAdd mip support to *DeferredTextureImageData functions.
As a first step, I want to add the ability to store multiple mip levels
in the opaque object.
I will follow this with using SkMipMap to generate and store the mip
levels and generating the texture from those stored mip levels.
R=bsalomon@chromium.org
CC=ericrk@chromium.org
BUG=578304
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2023573002
Committed: https://skia.googlesource.com/skia/+/2c05280a0f792fc94c879e29011312a57532786b
Patch Set 1 #Patch Set 2 : Adding assert that we only received one mip level. #Patch Set 3 : Fixing build errors. #Patch Set 4 : Fixing MSVC build. #Messages
Total messages: 24 (10 generated)
Description was changed from ========== Add mip support to *DeferredTextureImageData functions. As a first step, I want to add the ability to store multiple mip levels in the opaque object. I will follow this with using SkMipMap to generate and store the mip levels and generating the texture from those stored mip levels. R=bsalomon@chromium.org CC=ericrk@chromium.org BUG=578304 ========== to ========== Add mip support to *DeferredTextureImageData functions. As a first step, I want to add the ability to store multiple mip levels in the opaque object. I will follow this with using SkMipMap to generate and store the mip levels and generating the texture from those stored mip levels. R=bsalomon@chromium.org CC=ericrk@chromium.org BUG=578304 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2023573002 ==========
PTAL
The CQ bit was checked by cblume@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023573002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
The CQ bit was checked by cblume@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023573002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023573002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)
The CQ bit was checked by cblume@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023573002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023573002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
cblume@chromium.org changed reviewers: + bsalomon@google.com - bsalomon@chromium.org
-bsalomon_chromium +bsalomon
Is there a good way to test this?
The offsets to pixels *could* be implicit (both before this change and with the addition of MIP levels). However, I don't think a ptr per level is worth a lot of fuss. LGTM.
On 2016/05/31 16:23:05, bsalomon wrote: > The offsets to pixels *could* be implicit (both before this change and with the > addition of MIP levels). However, I don't think a ptr per level is worth a lot > of fuss. LGTM.
On 2016/05/31 16:23:05, bsalomon wrote: > The offsets to pixels *could* be implicit (both before this change and with the > addition of MIP levels). However, I don't think a ptr per level is worth a lot > of fuss. LGTM. I'm happy to make that change in another CL if you would like.
The CQ bit was checked by cblume@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023573002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023573002/60001
Message was sent while issue was closed.
Description was changed from ========== Add mip support to *DeferredTextureImageData functions. As a first step, I want to add the ability to store multiple mip levels in the opaque object. I will follow this with using SkMipMap to generate and store the mip levels and generating the texture from those stored mip levels. R=bsalomon@chromium.org CC=ericrk@chromium.org BUG=578304 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2023573002 ========== to ========== Add mip support to *DeferredTextureImageData functions. As a first step, I want to add the ability to store multiple mip levels in the opaque object. I will follow this with using SkMipMap to generate and store the mip levels and generating the texture from those stored mip levels. R=bsalomon@chromium.org CC=ericrk@chromium.org BUG=578304 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2023573002 Committed: https://skia.googlesource.com/skia/+/2c05280a0f792fc94c879e29011312a57532786b ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/2c05280a0f792fc94c879e29011312a57532786b |
