Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2023553002: Measure text autosizing in the wild (Closed)

Created:
4 years, 6 months ago by pdr.
Modified:
4 years, 6 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Measure text autosizing in the wild This patch re-adds the TextAutosizing UseCounter metric to measure the percentage of pages which actually autosize. This has been put in TextAutosizer::inflate instead of TextAutosizer::applyMultiplier because the latter is called much more often and a branch could affect performance. https://www.chromestatus.com/metrics/feature/timeline/popularity/274 BUG=615536 Committed: https://crrev.com/66d915b57a58f1a7ac96470af1d0abb1531d80b4 Cr-Commit-Position: refs/heads/master@{#396607}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/TextAutosizer.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
pdr.
4 years, 6 months ago (2016-05-27 22:30:01 UTC) #2
pdr.
PTAL
4 years, 6 months ago (2016-05-27 22:30:06 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023553002/1
4 years, 6 months ago (2016-05-27 22:30:30 UTC) #5
chrishtr
lgtm
4 years, 6 months ago (2016-05-27 22:32:05 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-28 00:10:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023553002/1
4 years, 6 months ago (2016-05-28 00:11:34 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-28 00:16:14 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-05-28 00:17:39 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/66d915b57a58f1a7ac96470af1d0abb1531d80b4
Cr-Commit-Position: refs/heads/master@{#396607}

Powered by Google App Engine
This is Rietveld 408576698