Fix display of "new" avatar menu in guest mode.

Fix display of "new" avatar menu in guest mode.

I would add a test for this, but one already exists, it's just disabled:
BrowserCommandControllerBrowserTest.NewAvatarMenuEnabledInGuestMode

BUG=471953, 614607
Committed: https://crrev.com/0890a13446558add03f85ec0f50b2d14967b467c
Cr-Commit-Position: refs/heads/master@{#396964}

[Evan Stade, 2016-05-27 20:01:26]

estade@chromium.org changed reviewers:
+ anthonyvd@chromium.org, pkasting@chromium.org

[Evan Stade, 2016-05-27 20:01:26]

https://codereview.chromium.org/2023523002/diff/1/chrome/browser/ui/views/fra...
File chrome/browser/ui/views/frame/avatar_button_manager.cc (right):

https://codereview.chromium.org/2023523002/diff/1/chrome/browser/ui/views/fra...
chrome/browser/ui/views/frame/avatar_button_manager.cc:32:
browser_view->IsOffTheRecord()) {
I failed to correctly copy (move) the logic from BrowserView::ShouldShowAvatar

[Peter Kasting, 2016-05-27 20:49:14]

LGTM; can we re-enable the test here?

[anthonyvd, 2016-05-27 20:57:10]

lgtm

[Evan Stade, 2016-05-31 21:31:16]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-05-31 21:31:19]

The CQ bit was unchecked by estade@chromium.org

[Evan Stade, 2016-05-31 21:33:10]

On 2016/05/27 20:49:14, Peter Kasting wrote:
> LGTM; can we re-enable the test here?

It's presumably still flaky.

[Evan Stade, 2016-05-31 21:33:12]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-05-31 21:34:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2023523002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2023523002/1

[commit-bot: I haz the power, 2016-05-31 23:04:59]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-31 23:06:31]

Description was changed from

==========
Fix display of "new" avatar menu in guest mode.

I would add a test for this, but one already exists, it's just disabled:
BrowserCommandControllerBrowserTest.NewAvatarMenuEnabledInGuestMode

BUG=471953,614607
==========

to

==========
Fix display of "new" avatar menu in guest mode.

I would add a test for this, but one already exists, it's just disabled:
BrowserCommandControllerBrowserTest.NewAvatarMenuEnabledInGuestMode

BUG=471953,614607

Committed: https://crrev.com/0890a13446558add03f85ec0f50b2d14967b467c
Cr-Commit-Position: refs/heads/master@{#396964}
==========

[commit-bot: I haz the power, 2016-05-31 23:06:32]

Patchset 1 (id:??) landed as
https://crrev.com/0890a13446558add03f85ec0f50b2d14967b467c
Cr-Commit-Position: refs/heads/master@{#396964}