Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: content/browser/accessibility/dump_accessibility_browsertest_base.cc

Issue 2023453003: Make RenderFrameHostImpl::GetRenderWidgetHost() always return an object (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing creis' comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/browser_plugin/browser_plugin_guest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/accessibility/dump_accessibility_browsertest_base.cc
diff --git a/content/browser/accessibility/dump_accessibility_browsertest_base.cc b/content/browser/accessibility/dump_accessibility_browsertest_base.cc
index 0c09681752226a2b0bb249d9d5c6e58acba5a8d1..1dea550b6517b3bb381bcd4a65c521d21fa64ea4 100644
--- a/content/browser/accessibility/dump_accessibility_browsertest_base.cc
+++ b/content/browser/accessibility/dump_accessibility_browsertest_base.cc
@@ -267,12 +267,10 @@ void DumpAccessibilityTestBase::RunTestForPlatform(
// We won't get the correct coordinate transformations for
// out-of-process iframes until each frame's surface is ready.
RenderFrameHostImpl* current_frame_host = node->current_frame_host();
- if (!current_frame_host)
+ if (!current_frame_host || !current_frame_host->is_local_root())
continue;
- RenderWidgetHostImpl* rwh = current_frame_host->GetRenderWidgetHost();
- if (!rwh)
- continue;
- RenderWidgetHostViewBase* rwhv = rwh->GetView();
+ RenderWidgetHostViewBase* rwhv =
+ static_cast<RenderWidgetHostViewBase*>(current_frame_host->GetView());
if (rwhv && rwhv->IsChildFrameForTesting()) {
SurfaceHitTestReadyNotifier notifier(
static_cast<RenderWidgetHostViewChildFrame*>(rwhv));
« no previous file with comments | « no previous file | content/browser/browser_plugin/browser_plugin_guest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698