Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 2023453002: MD links - underline to indicate focus. (Closed)

Created:
4 years, 6 months ago by Evan Stade
Modified:
4 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD links - underline to indicate focus. As discussed with sgabriel@; this is somewhat exploratory. We can't reuse the bold treatment that polymer uses as many fonts change width when emboldened. BUG=571500, 591140 Committed: https://crrev.com/de354e47c0ee02b889343db624b1996df7322c2f Cr-Commit-Position: refs/heads/master@{#396574}

Patch Set 1 #

Patch Set 2 : fix website settings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M chrome/browser/ui/views/website_settings/website_settings_popup_view.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M ui/views/controls/label.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/controls/link.cc View 1 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Evan Stade
4 years, 6 months ago (2016-05-27 18:17:59 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023453002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023453002/20001
4 years, 6 months ago (2016-05-27 18:18:51 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-27 19:47:17 UTC) #8
sky
Ugh, focused labels will look like links. LGTM
4 years, 6 months ago (2016-05-27 21:42:29 UTC) #9
Evan Stade
On 2016/05/27 21:42:29, sky wrote: > Ugh, focused labels will look like links. > > ...
4 years, 6 months ago (2016-05-27 21:48:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023453002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023453002/20001
4 years, 6 months ago (2016-05-27 21:48:57 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-27 21:53:24 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 21:55:37 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/de354e47c0ee02b889343db624b1996df7322c2f
Cr-Commit-Position: refs/heads/master@{#396574}

Powered by Google App Engine
This is Rietveld 408576698