Convert buildParameter() into a factory constructor.

Convert buildParameter() into a factory constructor.

Also resynthesize function typed parameter types lazily.

R=paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/5317a2b526bd11885800eda1973111f33e27e36a

[Paul Berry, 2016-05-27 21:51:20]

lgtm

https://codereview.chromium.org/2023443003/diff/1/pkg/analyzer/lib/src/dart/e...
File pkg/analyzer/lib/src/dart/element/element.dart (right):

https://codereview.chromium.org/2023443003/diff/1/pkg/analyzer/lib/src/dart/e...
pkg/analyzer/lib/src/dart/element/element.dart:6241: type; // _parameters is set
during computing 'type'
Even with the comment, this code looks very strange and I worry someone would be
tempted to delete it.  Consider extracting everything but the last line in
`type` to a method called "_setTypeAndParameters()", and call it from here
rather than calling the getter.

[scheglov, 2016-05-27 21:57:04]

https://codereview.chromium.org/2023443003/diff/1/pkg/analyzer/lib/src/dart/e...
File pkg/analyzer/lib/src/dart/element/element.dart (right):

https://codereview.chromium.org/2023443003/diff/1/pkg/analyzer/lib/src/dart/e...
pkg/analyzer/lib/src/dart/element/element.dart:6241: type; // _parameters is set
during computing 'type'
On 2016/05/27 21:51:20, Paul Berry wrote:
> Even with the comment, this code looks very strange and I worry someone would
be
> tempted to delete it.  Consider extracting everything but the last line in
> `type` to a method called "_setTypeAndParameters()", and call it from here
> rather than calling the getter.

Done.

[scheglov, 2016-05-27 21:57:31]

Description was changed from

==========
Convert buildParameter() into a factory constructor.

Also resynthesize function typed parameter types lazily.

R=paulberry@google.com
BUG=
==========

to

==========
Convert buildParameter() into a factory constructor.

Also resynthesize function typed parameter types lazily.

R=paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/5317a2b526bd11885800eda1973111f33e27e36a
==========

[scheglov, 2016-05-27 21:57:33]

Committed patchset #1 (id:1) manually as
5317a2b526bd11885800eda1973111f33e27e36a (presubmit successful).