Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 202343003: Early return when doing tagName based adjustments in StyleAdjuster (Closed)

Created:
6 years, 9 months ago by esprehn
Modified:
6 years, 9 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Visibility:
Public.

Description

Early return when doing tagName based adjustments in StyleAdjuster adjustRenderStyle is 2% of the recalcStyle cost and 1.5% of the time in the peacekeeper benchmark. This patch adds an early out when adjusting the element's style based on the tagName since after one match on the tagName no other cases can match. It also adds a check for <div> and <span> which are the most common elements and never need adjustment to skip all the rest of the tagName checks. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169406

Patch Set 1 #

Patch Set 2 : -> to . #

Patch Set 3 : typo #

Patch Set 4 : Never skip applying intrinsic margins #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -70 lines) Patch
M Source/core/css/resolver/StyleAdjuster.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/resolver/StyleAdjuster.cpp View 1 2 3 4 chunks +87 lines, -70 lines 0 comments Download

Messages

Total messages: 24 (0 generated)
esprehn
6 years, 9 months ago (2014-03-17 23:45:47 UTC) #1
eseidel
lgtm
6 years, 9 months ago (2014-03-17 23:49:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/202343003/1
6 years, 9 months ago (2014-03-17 23:49:15 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-17 23:53:08 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-17 23:53:09 UTC) #5
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 9 months ago (2014-03-18 00:01:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/202343003/1
6 years, 9 months ago (2014-03-18 00:01:56 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-18 00:02:57 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-18 00:02:58 UTC) #9
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 9 months ago (2014-03-18 00:04:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/202343003/20001
6 years, 9 months ago (2014-03-18 00:04:50 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-18 00:13:45 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 9 months ago (2014-03-18 00:13:46 UTC) #13
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 9 months ago (2014-03-18 00:16:35 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/202343003/40001
6 years, 9 months ago (2014-03-18 00:16:50 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-18 00:59:11 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-18 00:59:12 UTC) #17
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 9 months ago (2014-03-18 01:34:34 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/202343003/60001
6 years, 9 months ago (2014-03-18 01:34:41 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-18 03:23:40 UTC) #20
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-18 03:23:41 UTC) #21
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 9 months ago (2014-03-18 03:31:58 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/202343003/60001
6 years, 9 months ago (2014-03-18 03:32:07 UTC) #23
commit-bot: I haz the power
6 years, 9 months ago (2014-03-18 03:32:32 UTC) #24
Message was sent while issue was closed.
Change committed as 169406

Powered by Google App Engine
This is Rietveld 408576698