Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2023423002: Revert "VM: Add result cid information for recognized methods." (Closed)

Created:
4 years, 6 months ago by rmacnak
Modified:
4 years, 6 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "VM: Add result cid information for recognized methods." In Flutter, this caused RangeError (index): Index out of range: index should be less than null: 0 Uint32List.[]= (dart:typed_data) _HashVMBase&MapMixin&&_LinkedHashMapMixin._insert (dart:collection-patch/compact_hash.dart) This reverts commit 0ae4ae50331311caeeb67585ac4a0ed88063ca4c. TBR=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/907a6b1c3becc9c91c26ba8bbfb56623dc858e01

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+302 lines, -348 lines) Patch
M runtime/lib/typed_data.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 2 chunks +22 lines, -8 lines 0 comments Download
M runtime/vm/flow_graph_type_propagator.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/intrinsifier.h View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/intrinsifier.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/method_recognizer.h View 5 chunks +261 lines, -294 lines 0 comments Download
M runtime/vm/method_recognizer.cc View 3 chunks +3 lines, -15 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +7 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rmacnak
4 years, 6 months ago (2016-06-01 21:08:02 UTC) #1
rmacnak
Committed patchset #1 (id:1) manually as 907a6b1c3becc9c91c26ba8bbfb56623dc858e01 (presubmit successful).
4 years, 6 months ago (2016-06-01 21:08:56 UTC) #3
Florian Schneider
4 years, 6 months ago (2016-06-02 12:40:19 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698