Make the AwPixelInfo more skia version independent

android_webview/public/browser/draw_sw.h

Index: android_webview/public/browser/draw_sw.h
diff --git a/android_webview/public/browser/draw_sw.h b/android_webview/public/browser/draw_sw.h
index 2cdb45b3f3f2bb8195ddfdf33c87446a4ed5770b..dcdedfd9dcb40eea28bf31bbfa953efc6b302a7e 100644
--- a/android_webview/public/browser/draw_sw.h
+++ b/android_webview/public/browser/draw_sw.h
@@ -14,16 +14,30 @@
 
 class SkPicture;
 
+static const int kAwPixelInfoVersion = 2;

[Kristian Monsen, 2013/07/25 03:35:17]

Is the versioning for future compatibility reasons?

[joth, 2013/08/04 06:04:08]

yeah, I removed it from this patch, will do that separately (and consistently)

[joth, 2013/08/10 00:54:50]

reneged: it's more convenient having versioning info in each struct than
remembering to update a global version, so I left it here.

+
+// Values of the AwPixelInfo::config field.
+enum AwPixelConfig {
+  AwConfig_RGB_565 = 4,
+  AwConfig_ARGB_4444 = 5,
+  AwConfig_ARGB_8888 = 6,
+};
+
 // Holds the information required to implement the SW draw to system canvas.
 struct AwPixelInfo {
-  int config;         // In SkBitmap::Config format.
-  int width;          // In pixels.
-  int height;         // In pixels.
-  int row_bytes;      // Number of bytes from start of one line to next.
-  void* pixels;       // The pixels, all (height * row_bytes) of them.
-  float matrix[9];    // The matrix currently in effect on the canvas.
-  void* clip_region;  // Flattened clip region.
-  size_t clip_region_size;   // Number of bytes in |clip_region|.
+  AwPixelInfo() : version(kAwPixelInfoVersion) {}
+  int version;          // The kAwPixelInfoVersion this struct was built with.
+  int config;           // |pixel| format: a value from AwPixelConfig.
+  int width;            // In pixels.
+  int height;           // In pixels.
+  int row_bytes;        // Number of bytes from start of one line to next.
+  void* pixels;         // The pixels, all (height * row_bytes) of them.
+  // The Matrix and Clip are relative to |pixels|, not the source canvas.
+  float matrix[9];      // The matrix currently in effect on the canvas.
+  int clip_rect_count;  // Number of rects in |clip_rects|.
+  int* clip_rects;      // Clip area: 4 ints per rect in {x,y,w,h} format.
+  void* clip_region;    // TODO(joth): remove clip_region and clip_region_size.
+  size_t clip_region_size;
 };
 
 // Function that can be called to fish out the underlying native pixel data