Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 2023383003: media: Fix widevine_cdm_manifest target (Closed)

Created:
4 years, 6 months ago by xhwang
Modified:
4 years, 6 months ago
Reviewers:
ddorwin
CC:
chromium-reviews, eme-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Fix widevine_cdm_manifest target On Linux/ChromeOS, we don't use manifest.json for Widevine CDM. Therefore the "widevine_cdm_manifest_file" list is empty. Then, in a GYP build, copying an empty list to a destination will actually cause the whole folder where the gyp file is located to be copied. See BUG for more details. This CL fixes this issue by only coping the manifest when the list is not empty. BUG=615500 TEST=Tested on Linux where the list is empty and on Windows where the list is not empty. Committed: https://crrev.com/35e11eb20c09bef5c5b8ba0eb3b352ab314d94d3 Cr-Commit-Position: refs/heads/master@{#397308}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/widevine/cdm/widevine_cdm.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
xhwang
PTAL
4 years, 6 months ago (2016-06-01 21:59:32 UTC) #2
ddorwin
lgtm
4 years, 6 months ago (2016-06-01 23:21:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023383003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023383003/1
4 years, 6 months ago (2016-06-01 23:24:06 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/239418)
4 years, 6 months ago (2016-06-02 02:25:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023383003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023383003/1
4 years, 6 months ago (2016-06-02 03:55:31 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/239573)
4 years, 6 months ago (2016-06-02 04:45:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023383003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023383003/1
4 years, 6 months ago (2016-06-02 05:46:49 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 06:16:35 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 06:18:02 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/35e11eb20c09bef5c5b8ba0eb3b352ab314d94d3
Cr-Commit-Position: refs/heads/master@{#397308}

Powered by Google App Engine
This is Rietveld 408576698