gdb-add-index now removes its temp directory

build/gdb-add-index

 #!/bin/bash
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 #
 # Saves the gdb index for a given binary and its shared library dependencies.
 #
 # This will run gdb index in parallel on a number of binaries using SIGUSR1
 # as the communication mechanism to simulate a semaphore. Because of the
 # nature of this technique, using "set -e" is very difficult. The SIGUSR1
@@ skipping 18 matching lines @@
   trap "" EXIT USR1  # Avoid reentrancy.
 
   local jobs=$(jobs -p)
   if [ -n "$jobs" ]; then
     echo -n "Killing outstanding index jobs..."
     kill -KILL $(jobs -p)
     wait
     echo "done"
   fi
 
-  if [ -f "$directory" ]; then
+  if [ -d "$directory" ]; then
     echo -n "Removing temp directory $directory..."
     rm -rf "$directory"
     echo done
   fi
 }
 
 # Add index to one binary.
 function index_one_file {
   local file=$1
   local basename=$(basename "$file")
@@ skipping 125 matching lines @@
 
 # Do a wait loop. Bash waits that terminate due a trap have an exit
 # code > 128. We also ensure that our subshell's "normal" exit occurs with
 # an exit code > 128. This allows us to do consider a > 128 exit code as
 # an indication that the loop should continue. Unfortunately, it also means
 # we cannot use set -e since technically the "wait" is failing.
 wait
 while (($? > 128)); do
   wait
 done