Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 202333004: Move ParsePostfixExpression into ParserBase. (Closed)

Created:
6 years, 9 months ago by marja
Modified:
6 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Move ParsePostfixExpression into ParserBase. + enable a test which checks that Parser and PreParser produce the "invalid left hand side" errors consistently. R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=20149

Patch Set 1 #

Total comments: 2

Patch Set 2 : activated a test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -74 lines) Patch
M src/parser.h View 3 chunks +1 line, -7 lines 0 comments Download
M src/parser.cc View 2 chunks +2 lines, -33 lines 0 comments Download
M src/preparser.h View 8 chunks +43 lines, -10 lines 0 comments Download
M src/preparser.cc View 2 chunks +2 lines, -19 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 3 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
marja
mstarzinger, ptal
6 years, 9 months ago (2014-03-20 13:46:13 UTC) #1
Michael Starzinger
LGTM. https://codereview.chromium.org/202333004/diff/1/test/cctest/test-parsing.cc File test/cctest/test-parsing.cc (right): https://codereview.chromium.org/202333004/diff/1/test/cctest/test-parsing.cc#newcode2335 test/cctest/test-parsing.cc:2335: // TODO(marja): Activate this test once the preparser ...
6 years, 9 months ago (2014-03-21 09:24:36 UTC) #2
marja
thx for review! https://codereview.chromium.org/202333004/diff/1/test/cctest/test-parsing.cc File test/cctest/test-parsing.cc (right): https://codereview.chromium.org/202333004/diff/1/test/cctest/test-parsing.cc#newcode2335 test/cctest/test-parsing.cc:2335: // TODO(marja): Activate this test once ...
6 years, 9 months ago (2014-03-21 09:28:35 UTC) #3
marja
6 years, 9 months ago (2014-03-21 09:46:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r20149 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698