DescriptionReland of Use valid log callback for audio modem's audio recorder. (patchset #1 id:1 of https://codereview.chromium.org/2028083002/ )
Reason for revert:
The revert failed to fix the bot that was failing, so relanding.
Original issue's description:
> Revert of Use valid log callback for audio modem's audio recorder. (patchset #1 id:1 of https://codereview.chromium.org/2028023002/ )
>
> Reason for revert:
> Temporarily reverting this, as the revert is required to revert https://codereview.chromium.org/2022023002/ which is suspect of causing bot failures.
>
> Will reland if the reverts don't work.
>
> Original issue's description:
> > Use valid log callback for audio modem's audio recorder.
> >
> > This fixes a crash.
> >
> > Also change dchecks to checks to catch early. In the unit test we use a mock stream, and there's obviously no (debug built) integration test for this.
> >
> > BUG=616083
> > TBR=tommi@chromium.org, xiyuan@chromium.org
> >
> > Committed: https://crrev.com/9d6c6d9e13e8c263cf0a16c33eb39065ebb5a6eb
> > Cr-Commit-Position: refs/heads/master@{#397127}
>
> TBR=tommi@chromium.org,xiyuan@chromium.org,grunell@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=616083
>
> Committed: https://crrev.com/81395dce584e055f2ec5b126d366f19869865e29
> Cr-Commit-Position: refs/heads/master@{#397144}
TBR=tommi@chromium.org,xiyuan@chromium.org,grunell@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=616083
Committed: https://crrev.com/c48cb0e1928a7cff068d505d4de54b71d71c49ea
Cr-Commit-Position: refs/heads/master@{#397169}
Patch Set 1 #
Messages
Total messages: 6 (2 generated)
|