OfflinePageModel cleanups - improved CanSavePage() and moved static kInvalidOfflineId to impl

chrome/browser/android/offline_pages/offline_page_bridge.cc

Index: chrome/browser/android/offline_pages/offline_page_bridge.cc
diff --git a/chrome/browser/android/offline_pages/offline_page_bridge.cc b/chrome/browser/android/offline_pages/offline_page_bridge.cc
index ddd282ffdf3990ee9fde81fa7596af0517073292..c9d6fe9f065e685739cba96dc485fe0eb4038a76 100644
--- a/chrome/browser/android/offline_pages/offline_page_bridge.cc
+++ b/chrome/browser/android/offline_pages/offline_page_bridge.cc
@@ -5,7 +5,10 @@
 #include "chrome/browser/android/offline_pages/offline_page_bridge.h"
 
 #include <memory>
+#include <set>
+#include <string>
 #include <utility>
+#include <vector>
 
 #include "base/android/jni_array.h"
 #include "base/android/jni_string.h"
@@ -151,8 +154,7 @@ static jboolean IsBackgroundLoadingEnabled(JNIEnv* env,
 static jboolean CanSavePage(JNIEnv* env,
                             const JavaParamRef<jclass>& clazz,
                             const JavaParamRef<jstring>& j_url) {
-  GURL url(ConvertJavaStringToUTF8(env, j_url));
-  return url.is_valid() && OfflinePageModel::CanSavePage(url);
+  return OfflinePageModel::CanSaveURL(ConvertJavaStringToUTF8(env, j_url));

[fgorski, 2016/06/02 16:41:56]

As you've noticed compilers are not happy, because GURL as explicit constructor.
What dewittj@ meant was:
return OfflinePageModel::CanSaveURL(GURL(ConvertJavaStringToUTF8(env, j_url)));

[dougarnett, 2016/06/02 18:30:55]

Thanks - I do wonder now about the nit then - seems less readable to me so
putting back as I think the readability nit outweighs saving a line nit.

 }
 
 static ScopedJavaLocalRef<jobject> GetOfflinePageBridgeForProfile(