Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: chrome/browser/android/offline_pages/offline_page_bridge.cc

Issue 2023293002: OfflinePageModel cleanups - improved CanSavePage() and moved static kInvalidOfflineId to impl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/offline_page_bridge.cc
diff --git a/chrome/browser/android/offline_pages/offline_page_bridge.cc b/chrome/browser/android/offline_pages/offline_page_bridge.cc
index ddd282ffdf3990ee9fde81fa7596af0517073292..9404e76dbd305d1ebcfcc8b535f6158c03f409c5 100644
--- a/chrome/browser/android/offline_pages/offline_page_bridge.cc
+++ b/chrome/browser/android/offline_pages/offline_page_bridge.cc
@@ -5,7 +5,10 @@
#include "chrome/browser/android/offline_pages/offline_page_bridge.h"
#include <memory>
+#include <set>
+#include <string>
#include <utility>
+#include <vector>
#include "base/android/jni_array.h"
#include "base/android/jni_string.h"
@@ -152,7 +155,7 @@ static jboolean CanSavePage(JNIEnv* env,
const JavaParamRef<jclass>& clazz,
const JavaParamRef<jstring>& j_url) {
GURL url(ConvertJavaStringToUTF8(env, j_url));
- return url.is_valid() && OfflinePageModel::CanSavePage(url);
+ return OfflinePageUtils::CanSaveURL(url);
dewittj 2016/06/01 16:05:04 nit: just combine the two lines
dougarnett 2016/06/01 22:40:22 Done.
}
static ScopedJavaLocalRef<jobject> GetOfflinePageBridgeForProfile(

Powered by Google App Engine
This is Rietveld 408576698