Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: tracing/tracing/ui/analysis/analysis_view_test.html

Issue 2023283002: [polymer] Rewrite the analysis tab view (Closed) Base URL: git@github.com:zeptonaut/catapult.git@polymer10_rewrite_tab_view2
Patch Set: Code review Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/ui/analysis/analysis_view_test.html
diff --git a/tracing/tracing/ui/analysis/analysis_view_test.html b/tracing/tracing/ui/analysis/analysis_view_test.html
index 37776f819bd89412129cade0d4c2be03c3601038..7f88d256ab5bd0b8a6b968c65d724a4eb9e177f6 100644
--- a/tracing/tracing/ui/analysis/analysis_view_test.html
+++ b/tracing/tracing/ui/analysis/analysis_view_test.html
@@ -74,7 +74,7 @@ tr.b.unittest.testSuite(function() {
analysisView.brushingStateController = controller;
function checkSelectedTab(expectedSelectedTab, expectedRelatedEvents) {
- assert.strictEqual(tabView.selectedTab, expectedSelectedTab);
+ assert.strictEqual(tabView.selectedSubView, expectedSelectedTab);
assertEventSet(controller.currentBrushingState.analysisViewRelatedEvents,
expectedRelatedEvents);
}
@@ -99,7 +99,7 @@ tr.b.unittest.testSuite(function() {
checkSelectedTab(sampleTab2, []);
// 3. Tab selection: single thread slice tab.
- tabView.selectedTab = singleThreadSliceTab2;
+ tabView.selectedSubView = singleThreadSliceTab2;
checkSelectedTab(singleThreadSliceTab2, []);
// 4. Event selection: one sample, two thread slices, and one
@@ -111,8 +111,6 @@ tr.b.unittest.testSuite(function() {
checkTab(sampleTab4,
'tr-ui-a-counter-sample-sub-view',
[sample3]);
- // Reuse tab (same event type and sub-view tag name).
- assert.strictEqual(sampleTab4, sampleTab2);
var singleRecordTab4 = tabView.tabs[2];
checkTab(singleRecordTab4,
'tr-ui-a-single-user-expectation-sub-view',
@@ -125,7 +123,7 @@ tr.b.unittest.testSuite(function() {
checkSelectedTab(multiThreadSliceTab4, []);
// 5. Tab selection: single user expectation tab.
- tabView.selectedTab = singleRecordTab4;
+ tabView.selectedSubView = singleRecordTab4;
checkSelectedTab(singleRecordTab4, [sample1, slice1]);
// 6. Event selection: one user expectation.
@@ -136,8 +134,6 @@ tr.b.unittest.testSuite(function() {
checkTab(singleRecordTab6,
'tr-ui-a-single-user-expectation-sub-view',
[record2]);
- // Reuse tab (same event type and sub-view tag name).
- assert.strictEqual(singleRecordTab6, singleRecordTab4);
// Remember selected tab.
checkSelectedTab(singleRecordTab6, [sample2, sample3, slice1]);
});

Powered by Google App Engine
This is Rietveld 408576698