Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2023263002: sandwich: Move all NoState-Prefetch related code in sandwich_prefetch.py (Closed)

Created:
4 years, 6 months ago by gabadie
Modified:
4 years, 6 months ago
Reviewers:
pasko
CC:
chromium-reviews, mikecase+watch_chromium.org, gabadie+watch_chromium.org, jbudorick+watch_chromium.org, lizeb+watch-android-loading_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

sandwich: Move all NoState-Prefetch related code in sandwich_prefetch.py mv sandwich_misc.py -> sandwich_prefetch.py mv sandwich_task_builder.py -> sandwich_utils.py Move sandwich_utils.py's PrefetchTaskBuilder into sandwich_prefetch.py Make sandwich_prefetch.py's functions private. BUG=582080 Committed: https://crrev.com/bfb85a4a099be52f32cd462220d4608c03251866 Cr-Commit-Position: refs/heads/master@{#397154}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+330 lines, -800 lines) Patch
M tools/android/loading/sandwich.py View 4 chunks +10 lines, -10 lines 0 comments Download
M tools/android/loading/sandwich_metrics.py View 1 chunk +0 lines, -1 line 0 comments Download
D tools/android/loading/sandwich_misc.py View 1 chunk +0 lines, -402 lines 0 comments Download
D tools/android/loading/sandwich_misc_unittest.py View 1 chunk +0 lines, -59 lines 0 comments Download
A + tools/android/loading/sandwich_prefetch.py View 14 chunks +232 lines, -28 lines 0 comments Download
A + tools/android/loading/sandwich_prefetch_unittest.py View 2 chunks +12 lines, -12 lines 0 comments Download
D tools/android/loading/sandwich_task_builder.py View 1 chunk +0 lines, -288 lines 0 comments Download
A tools/android/loading/sandwich_utils.py View 1 chunk +76 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
gabadie
Named sandwich_prefetch.py instead of sandwich_prefetch_builder.py for consistency with sandwich_swr.py, but also for avoiding to long ...
4 years, 6 months ago (2016-06-01 14:58:11 UTC) #2
pasko
lgtm, neat, thank you
4 years, 6 months ago (2016-06-01 15:11:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023263002/1
4 years, 6 months ago (2016-06-01 15:11:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 16:00:00 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 16:01:31 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bfb85a4a099be52f32cd462220d4608c03251866
Cr-Commit-Position: refs/heads/master@{#397154}

Powered by Google App Engine
This is Rietveld 408576698