Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Unified Diff: content/browser/service_worker/service_worker_client_utils.cc

Issue 2023243002: Remove base::Tuple (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: lint fix Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_client_utils.cc
diff --git a/content/browser/service_worker/service_worker_client_utils.cc b/content/browser/service_worker/service_worker_client_utils.cc
index 2c7c1274f2efafeb86ac4f09b74f321f2137ae6e..031e8f13a01056bf340bcd8f58c2c18e8b7dc3e4 100644
--- a/content/browser/service_worker/service_worker_client_utils.cc
+++ b/content/browser/service_worker/service_worker_client_utils.cc
@@ -5,6 +5,7 @@
#include "content/browser/service_worker/service_worker_client_utils.h"
#include <algorithm>
+#include <tuple>
#include "base/macros.h"
#include "base/memory/ptr_util.h"
@@ -266,11 +267,11 @@ void DidNavigate(const base::WeakPtr<ServiceWorkerContextCore>& context,
void AddWindowClient(
ServiceWorkerProviderHost* host,
- std::vector<base::Tuple<int, int, std::string>>* client_info) {
+ std::vector<std::tuple<int, int, std::string>>* client_info) {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
if (host->client_type() != blink::WebServiceWorkerClientTypeWindow)
return;
- client_info->push_back(base::MakeTuple(host->process_id(), host->frame_id(),
+ client_info->push_back(std::make_tuple(host->process_id(), host->frame_id(),
host->client_uuid()));
}
@@ -295,7 +296,7 @@ void AddNonWindowClient(ServiceWorkerProviderHost* host,
void OnGetWindowClientsOnUI(
// The tuple contains process_id, frame_id, client_uuid.
- const std::vector<base::Tuple<int, int, std::string>>& clients_info,
+ const std::vector<std::tuple<int, int, std::string>>& clients_info,
const GURL& script_url,
const GetWindowClientsCallback& callback) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
@@ -303,7 +304,7 @@ void OnGetWindowClientsOnUI(
std::unique_ptr<ServiceWorkerClients> clients(new ServiceWorkerClients);
for (const auto& it : clients_info) {
ServiceWorkerClientInfo info = GetWindowClientInfoOnUI(
- base::get<0>(it), base::get<1>(it), base::get<2>(it));
+ std::get<0>(it), std::get<1>(it), std::get<2>(it));
// If the request to the provider_host returned an empty
// ServiceWorkerClientInfo, that means that it wasn't possible to associate
@@ -375,7 +376,7 @@ void GetWindowClients(const base::WeakPtr<ServiceWorkerVersion>& controller,
DCHECK(options.client_type == blink::WebServiceWorkerClientTypeWindow ||
options.client_type == blink::WebServiceWorkerClientTypeAll);
- std::vector<base::Tuple<int, int, std::string>> clients_info;
+ std::vector<std::tuple<int, int, std::string>> clients_info;
if (!options.include_uncontrolled) {
for (auto& controllee : controller->controllee_map())
AddWindowClient(controllee.second, &clients_info);
« no previous file with comments | « content/browser/resolve_proxy_msg_helper_unittest.cc ('k') | content/browser/service_worker/service_worker_handle_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698