Remove base::Tuple

Remove base::Tuple

base::Tuple has been an alias of std::tuple for the migration. And this
CL completes the migration by:
 - Replace base::Tuple with std::tuple,
 - Replace base::MakeTuple with std::make_tuple,
 - Replace base::get with std::get,
 - Remove base::Tuple, base::MakeTuple, base::get and base::MakeRefTuple

BUG=554987
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/1068f1bea70e391d918f3b517a535ab297beaee4
Cr-Commit-Position: refs/heads/master@{#397652}

[tzik, 2016-06-01 11:57:14]

Description was changed from

==========
Remove base::Tuple

BUG=
==========

to

==========
Remove base::Tuple

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[tzik, 2016-06-02 09:33:44]

Description was changed from

==========
Remove base::Tuple

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Remove base::Tuple

BUG=554987
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[tzik, 2016-06-02 16:38:15]

Description was changed from

==========
Remove base::Tuple

BUG=554987
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Remove base::Tuple

base::Tuple has been an alias of std::tuple for the migration. And this
CL completes the migration by:
 - Replace base::Tuple with std::tuple,
 - Replace base::MakeTuple with std::make_tuple,
 - Replace base::get with std::get,
 - Remove base::Tuple, base::MakeTuple, base::get and base::MakeRefTuple

BUG=554987
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[tzik, 2016-06-02 16:38:39]

tzik@chromium.org changed reviewers:
+ kinuko@chromium.org, thakis@chromium.org

[tzik, 2016-06-02 16:40:06]

tzik@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[tzik, 2016-06-02 16:43:09]

Could you guys PTAL to this as OWNERS?
thakis: //base, //chrome, and //tools
kinuko: //content
dalecurtis: //media

[Nico, 2016-06-02 16:56:18]

my files lgtm

https://codereview.chromium.org/2023243002/diff/160001/base/tuple.h
File base/tuple.h (right):

https://codereview.chromium.org/2023243002/diff/160001/base/tuple.h#newcode6
base/tuple.h:6: // and std::tuple.  The convenient MakeTuple() function takes
any number of
This needs updating.

// Use std::tuple as tuple type. This file contains helper functions
// for working with std::tuples.

https://codereview.chromium.org/2023243002/diff/160001/base/tuple.h#newcode16
base/tuple.h:16: //   Tuple<int, const char*> tuple_a(1, "wee");
std::tuple

https://codereview.chromium.org/2023243002/diff/160001/base/tuple_unittest.cc
File base/tuple_unittest.cc (right):

https://codereview.chromium.org/2023243002/diff/160001/base/tuple_unittest.cc...
base/tuple_unittest.cc:48: EXPECT_EQ(2, std::get<1>(t3));
hm, do we need to test std::tuple and std::get?

[DaleCurtis, 2016-06-02 18:50:38]

media/ lgtm

[kinuko, 2016-06-02 23:23:34]

content/ lgtm

[tzik, 2016-06-03 04:44:19]

https://codereview.chromium.org/2023243002/diff/160001/base/tuple.h
File base/tuple.h (right):

https://codereview.chromium.org/2023243002/diff/160001/base/tuple.h#newcode6
base/tuple.h:6: // and std::tuple.  The convenient MakeTuple() function takes
any number of
On 2016/06/02 16:56:18, Nico wrote:
> This needs updating.
> 
> // Use std::tuple as tuple type. This file contains helper functions
> // for working with std::tuples.

Done.

https://codereview.chromium.org/2023243002/diff/160001/base/tuple.h#newcode16
base/tuple.h:16: //   Tuple<int, const char*> tuple_a(1, "wee");
On 2016/06/02 16:56:18, Nico wrote:
> std::tuple

Done.

https://codereview.chromium.org/2023243002/diff/160001/base/tuple_unittest.cc
File base/tuple_unittest.cc (right):

https://codereview.chromium.org/2023243002/diff/160001/base/tuple_unittest.cc...
base/tuple_unittest.cc:48: EXPECT_EQ(2, std::get<1>(t3));
On 2016/06/02 16:56:18, Nico wrote:
> hm, do we need to test std::tuple and std::get?

Let me remove this part.

[tzik, 2016-06-03 04:44:27]

The CQ bit was checked by tzik@chromium.org

[tzik, 2016-06-03 04:44:28]

The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org,
thakis@chromium.org, dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/2023243002/#ps180001
(title: "update comment. s/Tuple/std::tuple/ in comment. retire std::get test.")

[commit-bot: I haz the power, 2016-06-03 04:44:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2023243002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2023243002/180001

[commit-bot: I haz the power, 2016-06-03 04:53:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-03 04:53:42]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tzik, 2016-06-03 04:58:10]

The CQ bit was checked by tzik@chromium.org

[tzik, 2016-06-03 04:58:11]

The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org,
thakis@chromium.org, dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/2023243002/#ps200001
(title: "lint fix")

[commit-bot: I haz the power, 2016-06-03 04:58:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2023243002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2023243002/200001

[commit-bot: I haz the power, 2016-06-03 07:25:32]

Description was changed from

==========
Remove base::Tuple

base::Tuple has been an alias of std::tuple for the migration. And this
CL completes the migration by:
 - Replace base::Tuple with std::tuple,
 - Replace base::MakeTuple with std::make_tuple,
 - Replace base::get with std::get,
 - Remove base::Tuple, base::MakeTuple, base::get and base::MakeRefTuple

BUG=554987
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Remove base::Tuple

base::Tuple has been an alias of std::tuple for the migration. And this
CL completes the migration by:
 - Replace base::Tuple with std::tuple,
 - Replace base::MakeTuple with std::make_tuple,
 - Replace base::get with std::get,
 - Remove base::Tuple, base::MakeTuple, base::get and base::MakeRefTuple

BUG=554987
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-06-03 07:25:35]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2016-06-03 07:27:07]

Description was changed from

==========
Remove base::Tuple

base::Tuple has been an alias of std::tuple for the migration. And this
CL completes the migration by:
 - Replace base::Tuple with std::tuple,
 - Replace base::MakeTuple with std::make_tuple,
 - Replace base::get with std::get,
 - Remove base::Tuple, base::MakeTuple, base::get and base::MakeRefTuple

BUG=554987
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Remove base::Tuple

base::Tuple has been an alias of std::tuple for the migration. And this
CL completes the migration by:
 - Replace base::Tuple with std::tuple,
 - Replace base::MakeTuple with std::make_tuple,
 - Replace base::get with std::get,
 - Remove base::Tuple, base::MakeTuple, base::get and base::MakeRefTuple

BUG=554987
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/1068f1bea70e391d918f3b517a535ab297beaee4
Cr-Commit-Position: refs/heads/master@{#397652}
==========

[commit-bot: I haz the power, 2016-06-03 07:27:10]

Patchset 11 (id:??) landed as
https://crrev.com/1068f1bea70e391d918f3b517a535ab297beaee4
Cr-Commit-Position: refs/heads/master@{#397652}