Add more WebGL pixel tests.

Add more WebGL pixel tests.

Added tests for antialiasing, alpha channel, and Chromium image.

BUG=607130
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/fc773b807b0d136aa17e2ac18a55bdd2810118bc
Cr-Commit-Position: refs/heads/master@{#397199}

[erikchen, 2016-06-01 01:52:26]

Description was changed from

==========
Add more WebGL pixel tests.

Added tests for antialiasing, alpha channel, and Chromium image.

BUG=607130
==========

to

==========
Add more WebGL pixel tests.

Added tests for antialiasing, alpha channel, and Chromium image.

BUG=607130
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[erikchen, 2016-06-01 01:52:41]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-01 01:53:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2023153002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2023153002/1

[erikchen, 2016-06-01 02:00:37]

erikchen@chromium.org changed reviewers:
+ kbr@chromium.org

[erikchen, 2016-06-01 02:00:37]

kbr: Please review.

[Ken Russell (switch to Gerrit), 2016-06-01 02:06:07]

Thanks for adding these. LGTM with a couple of comments.

https://codereview.chromium.org/2023153002/diff/1/content/test/data/gpu/pixel...
File content/test/data/gpu/pixel_webgl_util.js (right):

https://codereview.chromium.org/2023153002/diff/1/content/test/data/gpu/pixel...
content/test/data/gpu/pixel_webgl_util.js:31: {"alpha": alpha,
"antialias":antialias});
Could you add a TODO about testing premultiplyAlpha as well? That's a key one
where testing coverage is missing.

https://codereview.chromium.org/2023153002/diff/1/content/test/gpu/page_sets/...
File content/test/gpu/page_sets/pixel_tests.py (right):

https://codereview.chromium.org/2023153002/diff/1/content/test/gpu/page_sets/...
content/test/gpu/page_sets/pixel_tests.py:165: name=base_name +
'.WebGLGreenTriangle.NoAA.Alpha' + es3_suffix,
I think you'll need to suppress failures of these new tests on all platforms
temporarily until reference images are generated. Could you then double-check
them to make sure they look OK? Links to the images will be in the logs. Thanks.

[commit-bot: I haz the power, 2016-06-01 02:50:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-01 02:50:54]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[erikchen, 2016-06-01 17:07:03]

https://codereview.chromium.org/2023153002/diff/1/content/test/data/gpu/pixel...
File content/test/data/gpu/pixel_webgl_util.js (right):

https://codereview.chromium.org/2023153002/diff/1/content/test/data/gpu/pixel...
content/test/data/gpu/pixel_webgl_util.js:31: {"alpha": alpha,
"antialias":antialias});
On 2016/06/01 02:06:07, Ken Russell wrote:
> Could you add a TODO about testing premultiplyAlpha as well? That's a key one
> where testing coverage is missing.

Done.

https://codereview.chromium.org/2023153002/diff/1/content/test/gpu/page_sets/...
File content/test/gpu/page_sets/pixel_tests.py (right):

https://codereview.chromium.org/2023153002/diff/1/content/test/gpu/page_sets/...
content/test/gpu/page_sets/pixel_tests.py:165: name=base_name +
'.WebGLGreenTriangle.NoAA.Alpha' + es3_suffix,
On 2016/06/01 02:06:07, Ken Russell wrote:
> I think you'll need to suppress failures of these new tests on all platforms
> temporarily until reference images are generated. Could you then double-check
> them to make sure they look OK? Links to the images will be in the logs.
Thanks.

Done.

[erikchen, 2016-06-01 17:07:07]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-06-01 17:07:07]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/2023153002/#ps20001
(title: "Comments fmor kbr.")

[commit-bot: I haz the power, 2016-06-01 17:07:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2023153002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2023153002/20001

[commit-bot: I haz the power, 2016-06-01 18:59:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-01 19:11:53]

Description was changed from

==========
Add more WebGL pixel tests.

Added tests for antialiasing, alpha channel, and Chromium image.

BUG=607130
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add more WebGL pixel tests.

Added tests for antialiasing, alpha channel, and Chromium image.

BUG=607130
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/fc773b807b0d136aa17e2ac18a55bdd2810118bc
Cr-Commit-Position: refs/heads/master@{#397199}
==========

[commit-bot: I haz the power, 2016-06-01 19:11:53]

Patchset 2 (id:??) landed as
https://crrev.com/fc773b807b0d136aa17e2ac18a55bdd2810118bc
Cr-Commit-Position: refs/heads/master@{#397199}