Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Unified Diff: remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java

Issue 2023133002: Use Event to render feedback animations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Resolve review comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/android/java/src/org/chromium/chromoting/PaintEventParameter.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java
diff --git a/remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java b/remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java
index 8b6dbc258af8d8cc060b4c71d04786d93c65cf36..e31c2a3d83236669f74ad20ea4ffee1dbf5b65be 100644
--- a/remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java
+++ b/remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java
@@ -6,6 +6,7 @@ package org.chromium.chromoting;
import android.content.Context;
import android.graphics.Matrix;
+import android.graphics.Point;
import android.graphics.PointF;
import android.graphics.Rect;
import android.view.GestureDetector;
@@ -526,7 +527,11 @@ public class TouchInputHandler implements TouchInputHandlerInterface {
}
if (mInputStrategy.onTap(button)) {
- mViewer.showInputFeedback(mInputStrategy.getShortPressFeedbackType());
+ Point pos;
+ synchronized (mRenderData) {
+ pos = mRenderData.getCursorPosition();
+ }
+ mViewer.showInputFeedback(mInputStrategy.getShortPressFeedbackType(), pos);
}
return true;
}
@@ -544,7 +549,11 @@ public class TouchInputHandler implements TouchInputHandlerInterface {
}
if (mInputStrategy.onPressAndHold(button)) {
- mViewer.showInputFeedback(mInputStrategy.getLongPressFeedbackType());
+ Point pos;
+ synchronized (mRenderData) {
+ pos = mRenderData.getCursorPosition();
+ }
+ mViewer.showInputFeedback(mInputStrategy.getLongPressFeedbackType(), pos);
mSuppressFling = true;
mIsDragging = true;
}
« no previous file with comments | « remoting/android/java/src/org/chromium/chromoting/PaintEventParameter.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698