remoting/android/java/src/org/chromium/chromoting/DesktopViewInterface.java - Issue 2023133002: Use Event to render feedback animations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/android/java/src/org/chromium/chromoting/DesktopViewInterface.java

Issue 2023133002: Use Event to render feedback animations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Resolve review comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « remoting/android/java/src/org/chromium/chromoting/DesktopView.java ('k') | remoting/android/java/src/org/chromium/chromoting/FeedbackAnimator.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: remoting/android/java/src/org/chromium/chromoting/DesktopViewInterface.java

diff --git a/remoting/android/java/src/org/chromium/chromoting/DesktopViewInterface.java b/remoting/android/java/src/org/chromium/chromoting/DesktopViewInterface.java

index b9d3147a26b3aa6c050e52abe920b88d3b53dde8..41a29c178b6d75148e2da337488bbd3feeb9c8c6 100644

--- a/remoting/android/java/src/org/chromium/chromoting/DesktopViewInterface.java

+++ b/remoting/android/java/src/org/chromium/chromoting/DesktopViewInterface.java

@@ -4,12 +4,14 @@

package org.chromium.chromoting;

+import android.graphics.Point;

/**

* Callback interface to allow the TouchInputHandler to request actions on the DesktopView.

public interface DesktopViewInterface {

/** Triggers a brief animation to indicate the existence and location of an input event. */

- void showInputFeedback(DesktopView.InputFeedbackType feedbackToShow);

+ void showInputFeedback(DesktopView.InputFeedbackType feedbackToShow, Point pos);

/** Shows the action bar. */

void showActionBar();