Use Event to render feedback animations.

remoting/android/java/src/org/chromium/chromoting/TapGestureDetector.java

 // Copyright 2013 The Chromium Authors. All rights reserved.

[Lambros, 2016/06/01 23:51:36]

These bug-fixes and cleanups seem unrelated to this CL. Move them to another CL?

[Hzj_jie, 2016/06/02 02:21:37]

Sure.

 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chromoting;
 
 import android.content.Context;
 import android.graphics.PointF;
 import android.os.Handler;
 import android.os.Message;
 import android.util.SparseArray;
@@ skipping 23 matching lines @@
          * Notified when a long-touch event occurs.
          *
          * @param pointerCount The number of fingers held down.
          * @param x The x coordinate of the initial finger tapped.
          * @param y The y coordinate of the initial finger tapped.
          */
         void onLongPress(int pointerCount, float x, float y);
     }
 
     /** The listener to which notifications are sent. */
-    private OnTapListener mListener;
+    private final OnTapListener mListener;
 
     /** Handler used for posting tasks to be executed in the future. */
-    private Handler mHandler;
+    private final Handler mHandler;
 
     /** The maximum number of fingers seen in the gesture. */
     private int mPointerCount = 0;
 
     /** The coordinates of the first finger down seen in the gesture. */
     private PointF mInitialPoint;
 
     /**
      * Stores the location of each down MotionEvent (by pointer ID), for detecting motion of any
      * pointer beyond the TouchSlop region.
@@ skipping 15 matching lines @@
         private final WeakReference<TapGestureDetector> mDetector;
 
         public EventHandler(TapGestureDetector detector) {
             mDetector = new WeakReference<TapGestureDetector>(detector);
         }
 
         @Override
         public void handleMessage(Message message) {
             TapGestureDetector detector = mDetector.get();
             if (detector != null) {
+                detector.mTapCancelled = true;
                 detector.mListener.onLongPress(
                         detector.mPointerCount, detector.mInitialPoint.x, detector.mInitialPoint.y);
-                detector.mTapCancelled = true;
+                detector.mInitialPoint = null;
             }
         }
     }
 
     public TapGestureDetector(Context context, OnTapListener listener) {
         mListener = listener;
         mHandler = new EventHandler(this);
         ViewConfiguration config = ViewConfiguration.get(context);
         int touchSlop = config.getScaledTouchSlop();
         mTouchSlopSquare = touchSlop * touchSlop;
     }
 
     /** Analyzes the touch event to determine whether to notify the listener. */
     public boolean onTouchEvent(MotionEvent event) {
         boolean handled = false;
         switch (event.getActionMasked()) {
             case MotionEvent.ACTION_DOWN:
                 reset();
+                trackDownEvent(event);
                 // Cause a long-press notification to be triggered after the timeout.

[Lambros, 2016/06/01 23:51:37]

Blank line before comment.

[Hzj_jie, 2016/06/02 02:21:37]

Done.

                 mHandler.sendEmptyMessageDelayed(0, ViewConfiguration.getLongPressTimeout());
-                trackDownEvent(event);
                 mPointerCount = 1;
                 break;
 
             case MotionEvent.ACTION_POINTER_DOWN:
                 trackDownEvent(event);
                 mPointerCount = Math.max(mPointerCount, event.getPointerCount());
                 break;
 
             case MotionEvent.ACTION_MOVE:
                 if (!mTapCancelled) {
@@ skipping 86 matching lines @@
         mPointerCount = 0;
         mInitialPositions.clear();
         mTapCancelled = false;
     }
 
     /** Cancels any pending long-touch notifications from the message-queue. */
     private void cancelLongTouchNotification() {
         mHandler.removeMessages(0);
     }
 }