Fix bug of posting task inside constructor

Fix bug of posting task inside constructor

Refcounted object is initialized to have zero refcount and will be increased
to 1 in RefCountedThreadSafe::operator=(). There is a chance that
ConnectToHost finishes earlier than operator=(), which drops the refcount to
0 and triggers the d'tor.

Adding sleep(1) after PostTask() shows stable repro of this problem.

This CL fixes this problem by pulling the PostTask code out of the ctor.

BUG=615288
Committed: https://crrev.com/35c9e62b75248238526386edc44c46794adac095
Cr-Commit-Position: refs/heads/master@{#396961}

[Yuwei, 2016-05-31 21:26:34]

yuweih@chromium.org changed reviewers:
+ lambroslambrou@chromium.org

[Yuwei, 2016-05-31 21:26:35]

PTAL

[Yuwei, 2016-05-31 21:27:55]

The CQ bit was checked by yuweih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-31 21:29:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2023113002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2023113002/1

[Lambros, 2016-05-31 21:43:11]

lgtm

[commit-bot: I haz the power, 2016-05-31 22:40:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-31 22:40:27]

Dry run: This issue passed the CQ dry run.

[Yuwei, 2016-05-31 22:45:18]

The CQ bit was checked by yuweih@chromium.org

[commit-bot: I haz the power, 2016-05-31 22:46:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2023113002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2023113002/1

[commit-bot: I haz the power, 2016-05-31 22:51:07]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-31 22:52:06]

Description was changed from

==========
Fix bug of posting task inside constructor

Refcounted object is initialized to have zero refcount and will be increased
to 1 in RefCountedThreadSafe::operator=(). There is a chance that
ConnectToHost finishes earlier than operator=(), which drops the refcount to
0 and triggers the d'tor.

Adding sleep(1) after PostTask() shows stable repro of this problem.

This CL fixes this problem by pulling the PostTask code out of the ctor.

BUG=615288
==========

to

==========
Fix bug of posting task inside constructor

Refcounted object is initialized to have zero refcount and will be increased
to 1 in RefCountedThreadSafe::operator=(). There is a chance that
ConnectToHost finishes earlier than operator=(), which drops the refcount to
0 and triggers the d'tor.

Adding sleep(1) after PostTask() shows stable repro of this problem.

This CL fixes this problem by pulling the PostTask code out of the ctor.

BUG=615288

Committed: https://crrev.com/35c9e62b75248238526386edc44c46794adac095
Cr-Commit-Position: refs/heads/master@{#396961}
==========

[commit-bot: I haz the power, 2016-05-31 22:52:07]

Patchset 1 (id:??) landed as
https://crrev.com/35c9e62b75248238526386edc44c46794adac095
Cr-Commit-Position: refs/heads/master@{#396961}