Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Unified Diff: dm/DM.cpp

Issue 2023093004: Revert of Create SkColorSpaceXform to handle color conversions (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dm/DMSrcSink.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dm/DM.cpp
diff --git a/dm/DM.cpp b/dm/DM.cpp
index e17fd358d06ef4a489d941f74d2cc35d7bf851be..8ee2ea739f9dfc2da371dedb530f647c36c8acfe 100644
--- a/dm/DM.cpp
+++ b/dm/DM.cpp
@@ -724,15 +724,18 @@
return false;
}
+ // Load the dstSpace. This particular dst is fairly similar to Adobe RGB.
+ SkAutoTUnref<SkData> data(SkData::NewFromFileName(
+ GetResourcePath("monitor_profiles/HP_ZR30w.icc").c_str()));
+ sk_sp<SkColorSpace> dstSpace = SkColorSpace::NewICC(data->data(), data->size());
+ SkASSERT(dstSpace);
+
for (auto colorImage : colorImages) {
- ColorCodecSrc* src = new ColorCodecSrc(colorImage, ColorCodecSrc::kBaseline_Mode);
+ ColorCodecSrc* src = new ColorCodecSrc(colorImage, ColorCodecSrc::kBaseline_Mode, nullptr);
push_src("image", "color_codec_baseline", src);
- src = new ColorCodecSrc(colorImage, ColorCodecSrc::kDst_HPZR30w_Mode);
+ src = new ColorCodecSrc(colorImage, ColorCodecSrc::kDst_HPZR30w_Mode, dstSpace);
push_src("image", "color_codec_HPZR30w", src);
-
- src = new ColorCodecSrc(colorImage, ColorCodecSrc::kQCMS_HPZR30w_Mode);
- push_src("image", "color_codec_QCMS_HPZR30w", src);
}
return true;
« no previous file with comments | « no previous file | dm/DMSrcSink.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698