Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 2023093004: Revert of Create SkColorSpaceXform to handle color conversions (Closed)

Created:
4 years, 6 months ago by msarett
Modified:
4 years, 6 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Create SkColorSpaceXform to handle color conversions (patchset #10 id:260001 of https://codereview.chromium.org/1952063002/ ) Reason for revert: Google3 can't find qcms Original issue's description: > Create SkColorSpaceXform to handle color conversions > > Also adds testing of qcms color correction, so we can compare > SkColorSpaceXform outputs to qcms outputs. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1952063002 > > Committed: https://skia.googlesource.com/skia/+/740cc88ee3d63c75e52d31238f2a32600cc57a8c TBR=reed@google.com,scroggo@google.com,mtklein@google.com,herb@google.com,brianosman@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/4a603fc591dcd36b3cb47344c244ecbbbaf179f4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -264 lines) Patch
M dm/DM.cpp View 1 chunk +8 lines, -5 lines 0 comments Download
M dm/DMSrcSink.h View 2 chunks +2 lines, -4 lines 0 comments Download
M dm/DMSrcSink.cpp View 4 chunks +60 lines, -59 lines 0 comments Download
M gyp/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/ports.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/qcms.gyp View 1 chunk +1 line, -1 line 0 comments Download
M include/codec/SkCodec.h View 3 chunks +0 lines, -11 lines 0 comments Download
M src/codec/SkJpegCodec.h View 3 chunks +1 line, -6 lines 0 comments Download
M src/codec/SkJpegCodec.cpp View 6 chunks +7 lines, -16 lines 0 comments Download
D src/core/SkColorSpaceXform.h View 1 chunk +0 lines, -51 lines 0 comments Download
D src/core/SkColorSpaceXform.cpp View 1 chunk +0 lines, -109 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
msarett
Created Revert of Create SkColorSpaceXform to handle color conversions
4 years, 6 months ago (2016-06-01 16:15:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023093004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023093004/1
4 years, 6 months ago (2016-06-01 16:15:58 UTC) #3
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 16:16:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4a603fc591dcd36b3cb47344c244ecbbbaf179f4

Powered by Google App Engine
This is Rietveld 408576698