Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorterTest.cpp

Issue 2023093003: Upgrade in-document custom elements when an element is defined. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix ASAN failure in test helper. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorterTest.cpp
diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorterTest.cpp b/third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorterTest.cpp
index 03d5ffd5b6ccb7b3e871e33d8725b3ec2748936f..22b80ad5ec2d145cd33ec7979880a9a674538b6b 100644
--- a/third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorterTest.cpp
+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorterTest.cpp
@@ -20,7 +20,17 @@
namespace blink {
class CustomElementUpgradeSorterTest : public ::testing::Test {
-public:
+protected:
+ void SetUp() override
+ {
+ m_page = DummyPageHolder::create(IntSize(1, 1));
+ }
+
+ void TearDown() override
+ {
+ m_page = nullptr;
+ }
+
Element* createElementWithId(const char* localName, const char* id)
{
NonThrowableExceptionState noExceptions;
@@ -45,17 +55,6 @@ public:
element->attachShadow(scriptState(), shadowRootInit, noExceptions);
}
-protected:
- void SetUp() override
- {
- m_page = DummyPageHolder::create(IntSize(1, 1));
- }
-
- void TearDown() override
- {
- m_page = nullptr;
- }
-
private:
OwnPtr<DummyPageHolder> m_page;
};

Powered by Google App Engine
This is Rietveld 408576698