Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementReactionTestHelpers.h

Issue 2023093003: Upgrade in-document custom elements when an element is defined. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix ASAN failure in test helper. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/custom/CustomElementReactionTestHelpers.h
diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementReactionTestHelpers.h b/third_party/WebKit/Source/core/dom/custom/CustomElementReactionTestHelpers.h
index 3ab89c48b5e0c45cf43ffcd86a2e1b77cea7bd9e..e98e808ce5cc1d8862416a28e9c2680c1b125045 100644
--- a/third_party/WebKit/Source/core/dom/custom/CustomElementReactionTestHelpers.h
+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementReactionTestHelpers.h
@@ -17,8 +17,8 @@ class Element;
class Command : public GarbageCollectedFinalized<Command> {
WTF_MAKE_NONCOPYABLE(Command);
public:
- Command() { }
- virtual ~Command() { }
+ Command() = default;
+ virtual ~Command() = default;
DEFINE_INLINE_VIRTUAL_TRACE() { }
virtual void run(Element*) = 0;
};
@@ -27,7 +27,7 @@ class Log : public Command {
WTF_MAKE_NONCOPYABLE(Log);
public:
Log(char what, std::vector<char>& where) : m_what(what), m_where(where) { }
- virtual ~Log() { }
+ ~Log() override = default;
void run(Element*) override { m_where.push_back(m_what); }
private:
char m_what;
@@ -38,7 +38,7 @@ class Recurse : public Command {
WTF_MAKE_NONCOPYABLE(Recurse);
public:
Recurse(CustomElementReactionQueue* queue) : m_queue(queue) { }
- virtual ~Recurse() { }
+ ~Recurse() override = default;
DEFINE_INLINE_VIRTUAL_TRACE()
{
Command::trace(visitor);
@@ -57,7 +57,7 @@ public:
, m_reaction(reaction)
{
}
- virtual ~Enqueue() { }
+ ~Enqueue() override = default;
DEFINE_INLINE_VIRTUAL_TRACE()
{
Command::trace(visitor);
@@ -83,7 +83,7 @@ public:
for (auto& command : commands)
m_commands.append(command);
}
- virtual ~TestReaction() = default;
+ ~TestReaction() override = default;
DEFINE_INLINE_VIRTUAL_TRACE()
{
CustomElementReaction::trace(visitor);

Powered by Google App Engine
This is Rietveld 408576698