Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: ui/views/layout/layout_constants.h

Issue 2023093002: Reflow of the profile items in desktop user menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move-profile-icon
Patch Set: Addressed formatting & naming comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/layout/layout_constants.h
diff --git a/ui/views/layout/layout_constants.h b/ui/views/layout/layout_constants.h
index de062dd8aad96e324f166e90eff92aea55e41c2e..f3091644619686fa9ddb304f1b739f1daf14f717 100644
--- a/ui/views/layout/layout_constants.h
+++ b/ui/views/layout/layout_constants.h
@@ -27,6 +27,14 @@ const int kPanelVerticalSpacing = 32;
// Vertical spacing between sub UI.
const int kPanelSubVerticalSpacing = 24;
+// Vertical spacing between the edge of the menu and the top or bottom of the
+// menu items in material design.
Evan Stade 2016/06/10 17:39:46 I have no idea what menu this comment is referring
Jane 2016/06/10 18:49:16 I thought this would be a common constant used by
+const int kMaterialVerticalMargin = 16;
Evan Stade 2016/06/10 17:39:46 this is a rather unhelpful name. Pretend we're in
Jane 2016/06/10 18:49:16 Same thought but this name does need more details.
+
+// Horizontal spacing between the edge of the menu and the left or right of the
+// menu items in material design.
+const int kMaterialHorizontalMargin = 16;
+
// Vertical spacing between a label and some control.
const int kLabelToControlVerticalSpacing = 8;

Powered by Google App Engine
This is Rietveld 408576698