Reflow of the profile items in desktop user menu

ui/views/layout/layout_constants.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_LAYOUT_LAYOUT_CONSTANTS_H_
 #define UI_VIEWS_LAYOUT_LAYOUT_CONSTANTS_H_
 
 #include "build/build_config.h"
 #include "ui/views/layout/grid_layout.h"
 
 // This file contains some constants we use to implement our standard panel
 // layout.
 // see: spec 21/4
 
 namespace views {
 
 // Left or right margin.
 const int kPanelHorizMargin = 13;
 
 // Top or bottom margin.
 const int kPanelVertMargin = 13;
 
 // When several controls are aligned vertically, the baseline should be spaced
 // by the following number of pixels.
 const int kPanelVerticalSpacing = 32;
 
 // Vertical spacing between sub UI.
 const int kPanelSubVerticalSpacing = 24;
 
+// Vertical spacing between the edge of the material design user menu and the
+// top or bottom of the menu items.
+const int kMaterialMenuVerticalEdgeMargin = 16;

[Evan Stade, 2016/06/10 19:53:34]

I'm still confused about where this would be used besides in the user menu. Most
menu related constants live in ui/views/controls/menu/menu_config.h

I'd suggest moving this to the profile chooser view except I think the better
idea is to use a shared constant that already exists, once again to ensure
consistency.

[Jane, 2016/06/10 21:09:42]

Sorry, let me be more clear: I don't know exactly what menus will use this
margin value, but I was making an assumption that this parameter would be used
more commonly in the future when different Chrome components are converted to
standardized material design styles. But yes this was just my assumption. 
I added in this parameter because I couldn't find anything existing to use.
However, it does make sense to just move it to profile chooser view for now.
Done that, let me know if this works.

+
+// Horizontal spacing between the edge of the material design user menu and the
+// left or right of the menu items.
+const int kMaterialMenuHorizontalEdgeMargin = 16;
+
 // Vertical spacing between a label and some control.
 const int kLabelToControlVerticalSpacing = 8;
 
 // Small horizontal spacing between controls that are logically related.
 const int kRelatedControlSmallHorizontalSpacing = 8;
 
 // Horizontal spacing between controls that are logically related.
 const int kRelatedControlHorizontalSpacing = 8;
 
 // Vertical spacing between controls that are logically related.
@@ skipping 43 matching lines @@
 // Horizontal alignment used for a control's introductory label in a GridLayout.
 #if defined(OS_MACOSX)
 const GridLayout::Alignment kControlLabelGridAlignment = GridLayout::TRAILING;
 #else
 const GridLayout::Alignment kControlLabelGridAlignment = GridLayout::LEADING;
 #endif
 
 }  // namespace views
 
 #endif  // UI_VIEWS_LAYOUT_LAYOUT_CONSTANTS_H_