Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2023053002: [Android] Fix several bugs related to Snackbar Refactoring (Closed)

Created:
4 years, 6 months ago by Ian Wen
Modified:
4 years, 6 months ago
Reviewers:
Theresa
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Fix several bugs related to Snackbar Refactoring A flaw was introduced in the snackbar refactoring, which led to several touch handling errors. This CL fixes several of the recently discovered bugs. BUG=616013, 615826, 614698, 614614 Committed: https://crrev.com/8e99a89702ab51866a54a05106f8683183471304 Cr-Commit-Position: refs/heads/master@{#397234}

Patch Set 1 #

Total comments: 1

Patch Set 2 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -13 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarView.java View 1 7 chunks +28 lines, -12 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
Ian Wen
PTAL :)
4 years, 6 months ago (2016-05-31 19:14:52 UTC) #2
Theresa
lgtm https://codereview.chromium.org/2023053002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarView.java File chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarView.java (right): https://codereview.chromium.org/2023053002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarView.java#newcode158 chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarView.java:158: animatorSet.playTogether(fadeOut, moveDown); nit: set the duration on animatorSet ...
4 years, 6 months ago (2016-06-01 00:30:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023053002/20001
4 years, 6 months ago (2016-06-01 19:28:46 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-01 20:40:49 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 20:42:42 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8e99a89702ab51866a54a05106f8683183471304
Cr-Commit-Position: refs/heads/master@{#397234}

Powered by Google App Engine
This is Rietveld 408576698