Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: build/sanitizers/sanitizer_options.cc

Issue 2023033002: Enable in-process symbolization by default. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/sanitizers/sanitizer_options.cc
diff --git a/build/sanitizers/sanitizer_options.cc b/build/sanitizers/sanitizer_options.cc
index b06ec7e15254823b62473edeff09256bf9df7ba1..e01a17fddea323ac6892645758b8abb21f2f45a6 100644
--- a/build/sanitizers/sanitizer_options.cc
+++ b/build/sanitizers/sanitizer_options.cc
@@ -39,9 +39,7 @@ void _sanitizer_options_link_helper() { }
// for each malloc/free by 5 frames. These stack traces tend to accumulate
// very fast in applications using JIT (v8 in Chrome's case), see
// https://code.google.com/p/address-sanitizer/issues/detail?id=177
-// symbolize=false - disable the in-process symbolization, which isn't 100%
-// compatible with the existing sandboxes and doesn't make much sense for
-// stripped official binaries.
+// symbolize=1 - enable in-process symbolization.
// legacy_pthread_cond=1 - run in the libpthread 2.2.5 compatibility mode to
// work around libGL.so using the obsolete API, see
// http://crbug.com/341805. This may break if pthread_cond_t objects are
@@ -55,7 +53,6 @@ void _sanitizer_options_link_helper() { }
// for stack overflow detection.
// strip_path_prefix=Release/../../ - prefixes up to and including this
// substring will be stripped from source file paths in symbolized reports
-// (if symbolize=true, which is set when running with LeakSanitizer).
// fast_unwind_on_fatal=1 - use the fast (frame-pointer-based) stack unwinder
// to print error reports. V8 doesn't generate debug info for the JIT code,
// so the slow unwinder may not work properly.
@@ -68,12 +65,12 @@ void _sanitizer_options_link_helper() { }
// Chromium builds.
const char kAsanDefaultOptions[] =
"legacy_pthread_cond=1 malloc_context_size=5 "
- "symbolize=false check_printf=1 use_sigaltstack=1 detect_leaks=0 "
+ "symbolize=1 check_printf=1 use_sigaltstack=1 detect_leaks=0 "
"strip_path_prefix=Release/../../ fast_unwind_on_fatal=1";
#else
// Default AddressSanitizer options for buildbots and non-official builds.
const char *kAsanDefaultOptions =
- "symbolize=false check_printf=1 use_sigaltstack=1 "
+ "symbolize=1 check_printf=1 use_sigaltstack=1 "
"detect_leaks=0 strip_path_prefix=Release/../../ fast_unwind_on_fatal=1 "
"detect_stack_use_after_return=1 ";
#endif // GOOGLE_CHROME_BUILD
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698