Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2023023002: skiaserve: Add /quitquitquit handler. Will be used in the hosted debugger. (Closed)

Created:
4 years, 6 months ago by jcgregorio
Modified:
4 years, 6 months ago
Reviewers:
ethannicholas
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

skiaserve: Add /quitquitquit handler. Will be used in the hosted debugger. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2023023002 TBR=ethannicholas Committed: https://skia.googlesource.com/skia/+/ce8ea4c55b6ecaf7132edce46b1c1ed38d7437fd

Patch Set 1 #

Patch Set 2 : exit #

Patch Set 3 : space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M tools/skiaserve/skiaserve.cpp View 1 chunk +1 line, -0 lines 0 comments Download
A + tools/skiaserve/urlhandlers/QuitHandler.cpp View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
M tools/skiaserve/urlhandlers/UrlHandler.h View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
jcgregorio
4 years, 6 months ago (2016-05-31 18:00:50 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023023002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023023002/20001
4 years, 6 months ago (2016-05-31 18:57:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023023002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023023002/40001
4 years, 6 months ago (2016-05-31 19:24:40 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot/builds/3873)
4 years, 6 months ago (2016-05-31 19:32:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023023002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023023002/40001
4 years, 6 months ago (2016-05-31 19:44:17 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 19:51:34 UTC) #14
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/ce8ea4c55b6ecaf7132edce46b1c1ed38d7437fd

Powered by Google App Engine
This is Rietveld 408576698