Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2023013003: Change selected keyword search icon to the same icon used for default (Closed)

Created:
4 years, 6 months ago by Evan Stade
Modified:
4 years, 6 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change selected keyword search icon to the same icon used for default omnibox search. BUG=616191 TEST=looking glass should be the same size when tab to search is activated as when the omnibox is being used for a default search engine search Committed: https://crrev.com/7d14a9887968d5e4ff4710339b4848c39802ee6a Cr-Commit-Position: refs/heads/master@{#397036}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -57 lines) Patch
M chrome/browser/ui/views/location_bar/selected_keyword_view.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/gfx/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D ui/gfx/vector_icons/keyword_search.icon View 1 chunk +0 lines, -27 lines 0 comments Download
D ui/gfx/vector_icons/keyword_search.1x.icon View 1 chunk +0 lines, -27 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Evan Stade
4 years, 6 months ago (2016-06-01 01:13:34 UTC) #2
Peter Kasting
LGTM
4 years, 6 months ago (2016-06-01 01:23:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023013003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023013003/1
4 years, 6 months ago (2016-06-01 02:06:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 03:06:43 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 03:08:21 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d14a9887968d5e4ff4710339b4848c39802ee6a
Cr-Commit-Position: refs/heads/master@{#397036}

Powered by Google App Engine
This is Rietveld 408576698