Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 2023003004: Don't report android device port paths. (Closed)

Created:
4 years, 6 months ago by bpastene
Modified:
4 years, 6 months ago
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -104 lines) Patch
M infra/services/sysmon/android_device_metrics.py View 3 chunks +8 lines, -0 lines 2 comments Download
M infra/services/sysmon/test/android_device_metrics_test.py View 2 chunks +31 lines, -0 lines 0 comments Download
A + infra/services/sysmon/test/data/valid_files/some_port_paths.json View 3 chunks +6 lines, -104 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
bpastene
4 years, 6 months ago (2016-06-01 17:50:13 UTC) #2
ghost stip (do not use)
https://codereview.chromium.org/2023003004/diff/1/infra/services/sysmon/android_device_metrics.py File infra/services/sysmon/android_device_metrics.py (right): https://codereview.chromium.org/2023003004/diff/1/infra/services/sysmon/android_device_metrics.py#newcode58 infra/services/sysmon/android_device_metrics.py:58: logging.warning('Found port path %s as device id. Skipping.', interesting. ...
4 years, 6 months ago (2016-06-01 18:03:37 UTC) #3
bpastene
https://codereview.chromium.org/2023003004/diff/1/infra/services/sysmon/android_device_metrics.py File infra/services/sysmon/android_device_metrics.py (right): https://codereview.chromium.org/2023003004/diff/1/infra/services/sysmon/android_device_metrics.py#newcode58 infra/services/sysmon/android_device_metrics.py:58: logging.warning('Found port path %s as device id. Skipping.', On ...
4 years, 6 months ago (2016-06-01 21:43:30 UTC) #4
ghost stip (do not use)
cool. lgtm
4 years, 6 months ago (2016-06-01 23:27:59 UTC) #5
ghost stip (do not use)
we should look into tracking the 'unavailable' number as a metric though
4 years, 6 months ago (2016-06-01 23:28:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023003004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023003004/1
4 years, 6 months ago (2016-06-02 00:34:09 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 00:42:08 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/316fd863534efaa772b0d333cd7e5...

Powered by Google App Engine
This is Rietveld 408576698