Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: gpu/config/gpu_control_list.cc

Issue 2022983003: Roll base to 5e00da80f6adb7082d1c0e88d3274cf87cc43bc5 and tonic to f7acabb8fa6c91124486a41194eac3cd… (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/service/test_helper.cc ('k') | gpu/config/gpu_info_collector.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/config/gpu_control_list.cc
diff --git a/gpu/config/gpu_control_list.cc b/gpu/config/gpu_control_list.cc
index eaa2e61f30bba286efbaa701ef0af1f89028f3ed..4d72fa68a5b624e02a321741a69170fd17266839 100644
--- a/gpu/config/gpu_control_list.cc
+++ b/gpu/config/gpu_control_list.cc
@@ -24,8 +24,10 @@ namespace {
bool ProcessVersionString(const std::string& version_string,
char splitter,
std::vector<std::string>* version) {
+ char splitter_string[2] = {splitter, '\0'};
DCHECK(version);
- base::SplitString(version_string, splitter, version);
+ *version = base::SplitString(version_string, splitter_string,
+ base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
if (version->size() == 0)
return false;
// If the splitter is '-', we assume it's a date with format "mm-dd-yyyy";
@@ -1004,8 +1006,8 @@ bool GpuControlList::GpuControlListEntry::GLVersionInfoMismatch(
if (gl_version_info_.get() == NULL && gl_type_ == kGLTypeNone)
return false;
- std::vector<std::string> segments;
- base::SplitString(gl_version, ' ', &segments);
+ std::vector<std::string> segments = base::SplitString(
+ gl_version, " ", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
std::string number;
GLType gl_type = kGLTypeNone;
if (segments.size() > 2 &&
@@ -1015,7 +1017,8 @@ bool GpuControlList::GpuControlListEntry::GLVersionInfoMismatch(
gl_type = kGLTypeGLES;
if (segments.size() > 3 &&
- base::StartsWithASCII(segments[3], "(ANGLE", false)) {
+ base::StartsWith(segments[3], "(ANGLE",
+ base::CompareCase::INSENSITIVE_ASCII)) {
gl_type = kGLTypeANGLE;
}
} else {
« no previous file with comments | « gpu/command_buffer/service/test_helper.cc ('k') | gpu/config/gpu_info_collector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698