gpu/command_buffer/service/feature_info.cc - Issue 2022983003: Roll base to 5e00da80f6adb7082d1c0e88d3274cf87cc43bc5 and tonic to f7acabb8fa6c91124486a41194eac3cd…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/feature_info.cc

Issue 2022983003: Roll base to 5e00da80f6adb7082d1c0e88d3274cf87cc43bc5 and tonic to f7acabb8fa6c91124486a41194eac3cd… (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gpu/command_buffer/service/feature_info.cc

diff --git a/gpu/command_buffer/service/feature_info.cc b/gpu/command_buffer/service/feature_info.cc

index 8caca9414b9e10d4bb2726c248ab21557a22535d..502bfc2854548b94dbed290988c446f6033bd8d1 100644

--- a/gpu/command_buffer/service/feature_info.cc

+++ b/gpu/command_buffer/service/feature_info.cc

@@ -73,8 +73,8 @@ class StringSet {

void StringToWorkarounds(

const std::string& types, FeatureInfo::Workarounds* workarounds) {

DCHECK(workarounds);

- std::vector<std::string> pieces;

- base::SplitString(types, ',', &pieces);

+ std::vector<std::string> pieces = base::SplitString(

+ types, ",", base::KEEP_WHITESPACE, base::SPLIT_WANT_NONEMPTY);

for (size_t i = 0; i < pieces.size(); ++i) {

int number = 0;

bool succeed = base::StringToInt(pieces[i], &number);

« no previous file with comments | « gin/modules/file_module_provider.cc ('k') | gpu/command_buffer/service/gpu_tracer.cc » ('j') | no next file with comments »