apps/benchmark/benchmark_app.cc - Issue 2022983003: Roll base to 5e00da80f6adb7082d1c0e88d3274cf87cc43bc5 and tonic to f7acabb8fa6c91124486a41194eac3cd…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: apps/benchmark/benchmark_app.cc

Issue 2022983003: Roll base to 5e00da80f6adb7082d1c0e88d3274cf87cc43bc5 and tonic to f7acabb8fa6c91124486a41194eac3cd… (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: apps/benchmark/benchmark_app.cc

diff --git a/apps/benchmark/benchmark_app.cc b/apps/benchmark/benchmark_app.cc

index 12c2c509ca32b93ec769fd3f20638c1bd4e06466..3e2ea0b9d1a224c075ec888596d3942b9830350c 100644

--- a/apps/benchmark/benchmark_app.cc

+++ b/apps/benchmark/benchmark_app.cc

@@ -75,8 +75,9 @@ class BenchmarkApp : public mojo::ApplicationDelegate,

std::string ComputeCategoriesStr() {

std::set<std::string> category_set;

for (const Measurement& measurement : args_.measurements) {

- std::vector<std::string> categories;

- base::SplitString(measurement.target_event.categories, ',', &categories);

+ std::vector<std::string> categories =

+ base::SplitString(measurement.target_event.categories, ",",

+ base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);

category_set.insert(categories.begin(), categories.end());

}

std::vector<std::string> unique_categories(category_set.begin(),

« no previous file with comments | « DEPS ('k') | apps/benchmark/run_args.cc » ('j') | no next file with comments »