[predictor] Apply HSTS redirects when learning referrers.

[predictor] Apply HSTS redirects when learning referrers.

The net predictor skips HSTS redirects when issuing preconnects,
but doesn't do so when learning them. This patch changes
behavior such that if http://a.com shows up as a referrer
for b.com, we properly learn https://a.com => b.com if we know
that http://a.com redirects to https://a.com.

BUG=616219
Committed: https://crrev.com/1ffc3b20c2f695960e97696e750397e0bae4f1ea
Cr-Commit-Position: refs/heads/master@{#397254}

[Charlie Harrison, 2016-05-31 20:41:45]

Description was changed from

==========
[predictor] Apply HSTS redirects when learning referrers.

BUG=341726
==========

to

==========
[predictor] Apply HSTS redirects when learning referrers.

The net predictor skips HSTS redirects when issuing preconnects,
but doesn't do so when learning them. This patch changes
behavior such that if http://a.com shows up as a referrer
for b.com, we properly learn https://a.com => b.com if we know
 that http://a.com redirects to https://a.com.

BUG=341726
==========

[Charlie Harrison, 2016-05-31 20:42:42]

Description was changed from

==========
[predictor] Apply HSTS redirects when learning referrers.

The net predictor skips HSTS redirects when issuing preconnects,
but doesn't do so when learning them. This patch changes
behavior such that if http://a.com shows up as a referrer
for b.com, we properly learn https://a.com => b.com if we know
 that http://a.com redirects to https://a.com.

BUG=341726
==========

to

==========
[predictor] Apply HSTS redirects when learning referrers.

The net predictor skips HSTS redirects when issuing preconnects,
but doesn't do so when learning them. This patch changes
behavior such that if http://a.com shows up as a referrer
for b.com, we properly learn https://a.com => b.com if we know
that http://a.com redirects to https://a.com.

BUG=341726
==========

[Charlie Harrison, 2016-05-31 20:44:50]

csharrison@chromium.org changed reviewers:
+ mmenke@chromium.org

[Charlie Harrison, 2016-05-31 20:44:51]

Hey Matt, can you take a look at this one?

[Charlie Harrison, 2016-05-31 21:17:27]

Hold on, bots don't look happy. I'll fix those first.

[Charlie Harrison, 2016-05-31 21:17:32]

Hold on, bots don't look happy. I'll fix those first.

[Charlie Harrison, 2016-05-31 21:17:33]

Description was changed from

==========
[predictor] Apply HSTS redirects when learning referrers.

The net predictor skips HSTS redirects when issuing preconnects,
but doesn't do so when learning them. This patch changes
behavior such that if http://a.com shows up as a referrer
for b.com, we properly learn https://a.com => b.com if we know
that http://a.com redirects to https://a.com.

BUG=341726
==========

to

==========
[predictor] Apply HSTS redirects when learning referrers.

The net predictor skips HSTS redirects when issuing preconnects,
but doesn't do so when learning them. This patch changes
behavior such that if http://a.com shows up as a referrer
for b.com, we properly learn https://a.com => b.com if we know
that http://a.com redirects to https://a.com.

BUG=616219
==========

[mmenke, 2016-06-01 18:19:44]

LGTM

https://codereview.chromium.org/2022963003/diff/40001/chrome/browser/net/pred...
File chrome/browser/net/predictor_unittest.cc (right):

https://codereview.chromium.org/2022963003/diff/40001/chrome/browser/net/pred...
chrome/browser/net/predictor_unittest.cc:569:
predictor.LearnFromNavigation(kHttpUrl, kSubresourceUrl);
We'd also call predictor.LearnFromNavigation(kHttpUrl, kHttpsUrl); before this,
for the HSTS redirect, right?

[Charlie Harrison, 2016-06-01 19:50:35]

Thanks

https://codereview.chromium.org/2022963003/diff/40001/chrome/browser/net/pred...
File chrome/browser/net/predictor_unittest.cc (right):

https://codereview.chromium.org/2022963003/diff/40001/chrome/browser/net/pred...
chrome/browser/net/predictor_unittest.cc:569:
predictor.LearnFromNavigation(kHttpUrl, kSubresourceUrl);
On 2016/06/01 18:19:44, mmenke wrote:
> We'd also call predictor.LearnFromNavigation(kHttpUrl, kHttpsUrl); before
this,
> for the HSTS redirect, right?

Yeah we'd learn it. Do you think that fits in the unit test? I'm not sure if
that makes the test easier to understand or harder.

[mmenke, 2016-06-01 19:51:33]

On 2016/06/01 19:50:35, csharrison wrote:
> Thanks
> 
>
https://codereview.chromium.org/2022963003/diff/40001/chrome/browser/net/pred...
> File chrome/browser/net/predictor_unittest.cc (right):
> 
>
https://codereview.chromium.org/2022963003/diff/40001/chrome/browser/net/pred...
> chrome/browser/net/predictor_unittest.cc:569:
> predictor.LearnFromNavigation(kHttpUrl, kSubresourceUrl);
> On 2016/06/01 18:19:44, mmenke wrote:
> > We'd also call predictor.LearnFromNavigation(kHttpUrl, kHttpsUrl); before
> this,
> > for the HSTS redirect, right?
> 
> Yeah we'd learn it. Do you think that fits in the unit test? I'm not sure if
> that makes the test easier to understand or harder.

Maybe just add a comment?

[Charlie Harrison, 2016-06-01 20:01:21]

Thanks!

[Charlie Harrison, 2016-06-01 20:01:45]

The CQ bit was checked by csharrison@chromium.org

[Charlie Harrison, 2016-06-01 20:01:45]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/2022963003/#ps60001
(title: "add comment")

[commit-bot: I haz the power, 2016-06-01 20:03:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2022963003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2022963003/60001

[commit-bot: I haz the power, 2016-06-01 21:35:37]

Description was changed from

==========
[predictor] Apply HSTS redirects when learning referrers.

The net predictor skips HSTS redirects when issuing preconnects,
but doesn't do so when learning them. This patch changes
behavior such that if http://a.com shows up as a referrer
for b.com, we properly learn https://a.com => b.com if we know
that http://a.com redirects to https://a.com.

BUG=616219
==========

to

==========
[predictor] Apply HSTS redirects when learning referrers.

The net predictor skips HSTS redirects when issuing preconnects,
but doesn't do so when learning them. This patch changes
behavior such that if http://a.com shows up as a referrer
for b.com, we properly learn https://a.com => b.com if we know
that http://a.com redirects to https://a.com.

BUG=616219
==========

[commit-bot: I haz the power, 2016-06-01 21:35:38]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-01 21:37:16]

Description was changed from

==========
[predictor] Apply HSTS redirects when learning referrers.

The net predictor skips HSTS redirects when issuing preconnects,
but doesn't do so when learning them. This patch changes
behavior such that if http://a.com shows up as a referrer
for b.com, we properly learn https://a.com => b.com if we know
that http://a.com redirects to https://a.com.

BUG=616219
==========

to

==========
[predictor] Apply HSTS redirects when learning referrers.

The net predictor skips HSTS redirects when issuing preconnects,
but doesn't do so when learning them. This patch changes
behavior such that if http://a.com shows up as a referrer
for b.com, we properly learn https://a.com => b.com if we know
that http://a.com redirects to https://a.com.

BUG=616219

Committed: https://crrev.com/1ffc3b20c2f695960e97696e750397e0bae4f1ea
Cr-Commit-Position: refs/heads/master@{#397254}
==========

[commit-bot: I haz the power, 2016-06-01 21:37:17]

Patchset 4 (id:??) landed as
https://crrev.com/1ffc3b20c2f695960e97696e750397e0bae4f1ea
Cr-Commit-Position: refs/heads/master@{#397254}