Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: src/compiler/checkpoint-elimination.cc

Issue 2022913003: [turbofan] Implement simplistic checkpoint reducer. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Move into separate reducer. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/checkpoint-elimination.h ('k') | src/compiler/pipeline.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/checkpoint-elimination.cc
diff --git a/src/compiler/checkpoint-elimination.cc b/src/compiler/checkpoint-elimination.cc
new file mode 100644
index 0000000000000000000000000000000000000000..f852daa4ebb0d18a17e9ca6f61d30f52c5d1616e
--- /dev/null
+++ b/src/compiler/checkpoint-elimination.cc
@@ -0,0 +1,44 @@
+// Copyright 2016 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "src/compiler/checkpoint-elimination.h"
+
+#include "src/compiler/node-properties.h"
+
+namespace v8 {
+namespace internal {
+namespace compiler {
+
+CheckpointElimination::CheckpointElimination(Editor* editor)
+ : AdvancedReducer(editor) {}
+
+namespace {
+
+// The given checkpoint is redundant if it is effect-wise dominated by another
+// checkpoint and there is no observable write in between. For now we consider
+// a linear effect chain only instead of true effect-wise dominance.
+bool IsRedundantCheckPoint(Node* node) {
+ Node* effect = NodeProperties::GetEffectInput(node);
+ while (effect->op()->HasProperty(Operator::kNoWrite) &&
+ effect->op()->EffectInputCount() == 1) {
+ if (effect->opcode() == IrOpcode::kCheckPoint) return true;
+ effect = NodeProperties::GetEffectInput(effect);
+ }
+ return false;
+}
+
+} // namespace
+
+Reduction CheckpointElimination::Reduce(Node* node) {
+ if (node->opcode() != IrOpcode::kCheckPoint) return NoChange();
+ DCHECK_EQ(IrOpcode::kCheckPoint, node->opcode());
Benedikt Meurer 2016/06/01 04:05:22 The DCHECK_EQ is exactly the same as the check in
Michael Starzinger 2016/06/01 08:11:10 Done.
+ if (IsRedundantCheckPoint(node)) {
+ return Replace(NodeProperties::GetEffectInput(node));
+ }
+ return NoChange();
+}
+
+} // namespace compiler
+} // namespace internal
+} // namespace v8
« no previous file with comments | « src/compiler/checkpoint-elimination.h ('k') | src/compiler/pipeline.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698