Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(6)

Issue 2022913002: Revert of Add: check exploded time is properly converted (Closed)

Created:
3 years, 4 months ago by Guido Urdaneta
Modified:
3 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add: check exploded time is properly converted (patchset #7 id:340001 of https://codereview.chromium.org/1988663002/ ) Reason for revert: Suspect of breking Linux Tests bot. https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29?numbuilds=200 I will reland if the revert does not fix the bot. Original issue's description: > Add: check exploded time is properly converted. > > This cl introduces time checking in posix-like and mac systems. > base::Time::FromUTCExploded() and > base::Time::FromLocalExplode() can fail without returning > a proper error. > > This fix does the following: > 1) After calculations are done, create UTC or local time. > 2) Convert UTC or local time back to exploded > 3) Compare original exploded with converted one > 4) If times are not equal, then return Time(0) indicating > an error. > > Windows implementation already returns Time(0) on error. > > BUG=601900 > > Committed: https://crrev.com/ceba9fb480269695775191d14e98ab23b5918382 > Cr-Commit-Position: refs/heads/master@{#396638} TBR=mark@chromium.org,mmenke@chromium.org,eroman@chromium.org,maksim.sisov@intel.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=601900 Committed: https://crrev.com/8c687a70b52123f35c0504a5b3c5c84a639cebaf Cr-Commit-Position: refs/heads/master@{#396810}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -138 lines) Patch
M base/time/time.h View 4 chunks +4 lines, -30 lines 0 comments Download
M base/time/time.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M base/time/time_mac.cc View 3 chunks +4 lines, -24 lines 0 comments Download
M base/time/time_posix.cc View 2 chunks +3 lines, -21 lines 0 comments Download
M base/time/time_unittest.cc View 1 chunk +0 lines, -46 lines 0 comments Download
M base/time/time_win.cc View 3 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Guido Urdaneta
Created Revert of Add: check exploded time is properly converted
3 years, 4 months ago (2016-05-31 08:18:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2022913002/1
3 years, 4 months ago (2016-05-31 08:19:02 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 4 months ago (2016-05-31 10:21:41 UTC) #5
commit-bot: I haz the power
3 years, 4 months ago (2016-05-31 10:23:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c687a70b52123f35c0504a5b3c5c84a639cebaf
Cr-Commit-Position: refs/heads/master@{#396810}

Powered by Google App Engine
This is Rietveld 408576698