[MD settings] scroll to section find host

chrome/browser/resources/settings/settings_page/main_page_behavior.js

Index: chrome/browser/resources/settings/settings_page/main_page_behavior.js
diff --git a/chrome/browser/resources/settings/settings_page/main_page_behavior.js b/chrome/browser/resources/settings/settings_page/main_page_behavior.js
index 130a2881cdca9fca8e0c2f5934194daa3c515c59..9cbf9d61543e9f1160ab14b12acdccf6b9701346 100644
--- a/chrome/browser/resources/settings/settings_page/main_page_behavior.js
+++ b/chrome/browser/resources/settings/settings_page/main_page_behavior.js
@@ -335,6 +335,16 @@ var RoutableBehaviorImpl = {
     },
   },
 
+  /**

[Dan Beam, 2016/05/31 21:27:20]

@param?

[dschuyler, 2016/05/31 22:02:15]

Acknowledged.

+   * @return {Object} The enclosing (shadow dom) host of element.

[Dan Beam, 2016/05/31 21:27:20]

this should not be an object

[dschuyler, 2016/05/31 22:02:15]

Acknowledged.

+   * @private
+   */
+  findHost_: function(element) {
+    return findAncestor(element, function(node) {
+          return node.host;
+        }).host;

[Dan Beam, 2016/05/31 21:27:20]

can this be:

  return findAncestor(el, function(n) { return n.host; }).host;

[Dan Beam, 2016/05/31 21:27:20]

wrong indent

[dschuyler, 2016/05/31 22:02:14]

Acknowledged.

[dschuyler, 2016/05/31 22:02:15]

Acknowledged.

+  },
+
   /** @private */
   scrollToSection_: function() {
     // TODO(dschuyler): Determine whether this setTimeout can be removed.
@@ -346,7 +356,7 @@ var RoutableBehaviorImpl = {
       if (!element)
         return;
 

[Dan Beam, 2016/05/31 21:27:20]

or maybe:

var host = findAncestor(el, function(n) { return n.host; }).host;

[dschuyler, 2016/05/31 22:02:14]

Done.

-      if (element.parentNode.host.scrollHeight == 0) {
+      if (this.findHost_(element).scrollHeight == 0) {
         setTimeout(pollForScrollHeight.bind(this), 100);
         return;
       }