[MD settings] scroll to section find host

chrome/test/data/webui/settings/basic_page_browsertest.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @fileoverview Suite of tests for the Settings basic page. */
 
 GEN_INCLUDE(['settings_page_browsertest.js']);
 
 /**
  * @constructor
@@ skipping 33 matching lines @@
         sections.push('defaultBrowser');
       else
         sections = sections.concat(['internet', 'device']);
 
       for (var i = 0; i < sections.length; i++) {
         var section = self.getSection(page, sections[i]);
         expectTrue(!!section);
         self.verifySubpagesHidden(section);
       }
     });
+
+    // This test checks for a regression that occurred with scrollToSection_
+    // failing to find its host element.
+    test('scroll to section', function() {
+      // Setting the page and section will cause a scrollToSection_.
+      self.getPage('basic').currentRoute = {
+        page: 'basic',
+        section: 'onStartup',
+        subpage: [],
+      };
+
+      return new Promise(function(resolve, reject) {
+        function pollForVisibility() {
+          var page = self.getPage('basic')
+          var section = self.getSection(page, page.currentRoute.section);
+          if (!section)
+            setTimeout(pollForVisibility, 55);
+          else
+            resolve();
+        }
+        pollForVisibility();

[Dan Beam, 2016/05/31 22:10:29]

arguably:

var intervalId = window.setInterval(function() {
  var page = self.getPage('basic');
  var section = self.getSection(page, page.currentRoute.section);
  if (!section)
    return;

  window.clearInterval(intervalId);
  resolve();
}, 55);

or

setTimeout(function pollForVisibility() {
  var page = self.getPage('basic')
  var section = self.getSection(page, page.currentRoute.section);
  if (!section)
    setTimeout(pollForVisibility, 55);
  else
    resolve();
});

[dschuyler, 2016/05/31 22:25:02]

Done.

+      }.bind(self));
+    });
   });
 
   // Run all registered tests.
   mocha.run();
 });