[MD settings] scroll to section find host

chrome/browser/resources/settings/settings_page/main_page_behavior.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Fast out, slow in.
 var EASING_FUNCTION = 'cubic-bezier(0.4, 0, 0.2, 1)';
 var EXPAND_DURATION = 350;
 
 /**
  * Provides animations to expand and collapse individual sections in a page.
@@ skipping 317 matching lines @@
 var RoutableBehaviorImpl = {
   properties: {
     /** Contains the current route. */
     currentRoute: {
       type: Object,
       notify: true,
       observer: 'currentRouteChanged_',
     },
   },
 
+  /**

[Dan Beam, 2016/05/31 21:27:20]

@param?

[dschuyler, 2016/05/31 22:02:15]

Acknowledged.

+   * @return {Object} The enclosing (shadow dom) host of element.

[Dan Beam, 2016/05/31 21:27:20]

this should not be an object

[dschuyler, 2016/05/31 22:02:15]

Acknowledged.

+   * @private
+   */
+  findHost_: function(element) {
+    return findAncestor(element, function(node) {
+          return node.host;
+        }).host;

[Dan Beam, 2016/05/31 21:27:20]

can this be:

  return findAncestor(el, function(n) { return n.host; }).host;

[Dan Beam, 2016/05/31 21:27:20]

wrong indent

[dschuyler, 2016/05/31 22:02:14]

Acknowledged.

[dschuyler, 2016/05/31 22:02:15]

Acknowledged.

+  },
+
   /** @private */
   scrollToSection_: function() {
     // TODO(dschuyler): Determine whether this setTimeout can be removed.
     // See also: https://github.com/Polymer/polymer/issues/3629
     setTimeout(function pollForScrollHeight() {
       // If the current section changes while we are waiting for the page to be
       // ready, scroll to the newest requested section.
       var element = this.getSection_(this.currentRoute.section);
       if (!element)
         return;
 

[Dan Beam, 2016/05/31 21:27:20]

or maybe:

var host = findAncestor(el, function(n) { return n.host; }).host;

[dschuyler, 2016/05/31 22:02:14]

Done.

-      if (element.parentNode.host.scrollHeight == 0) {
+      if (this.findHost_(element).scrollHeight == 0) {
         setTimeout(pollForScrollHeight.bind(this), 100);
         return;
       }
 
       element.scrollIntoView();
     }.bind(this));
   },
 
   /** @private */
   currentRouteChanged_: function(newRoute, oldRoute) {
@@ skipping 36 matching lines @@
         this.$$('[section=' + section + ']'));
   },
 };
 
 
 /** @polymerBehavior */
 var RoutableBehavior = [
   MainPageBehavior,
   RoutableBehaviorImpl
 ];