Revert of [gn] Add unittests

BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/android/config.gni")
 import("//build/config/arm.gni")
 import("//build/config/mips.gni")
 import("//build/config/sanitizers/sanitizers.gni")
 
 if (is_android) {
@@ skipping 51 matching lines @@
   # Similar to vfp but on MIPS.
   v8_can_use_fpu_instructions = true
 
   # Similar to the ARM hard float ABI but on MIPS.
   v8_use_mips_abi_hardfloat = true
 }
 
 v8_random_seed = "314159265"
 v8_toolset_for_shell = "host"
 
+if (v8_use_snapshot && v8_use_external_startup_data) {
+  snapshot_target = ":v8_external_snapshot"
+} else if (v8_use_snapshot) {
+  snapshot_target = ":v8_snapshot"
+} else {
+  assert(!v8_use_external_startup_data)
+  snapshot_target = ":v8_nosnapshot"
+}
+
 ###############################################################################
 # Configurations
 #
 config("internal_config") {
   visibility = [ ":*" ]  # Only targets in this file can depend on this.
 
   include_dirs = [ "." ]
 
   if (is_component_build) {
     defines = [
@@ skipping 545 matching lines @@
       "--startup_blob",
       rebase_path("$root_out_dir/snapshot_blob.bin", root_build_dir),
     ]
   }
 }
 
 ###############################################################################
 # Source Sets (aka static libraries)
 #
 
-source_set("v8_maybe_snapshot") {
-  if (v8_use_snapshot && v8_use_external_startup_data) {
-    public_deps = [ ":v8_external_snapshot" ]
-  } else if (v8_use_snapshot) {
-    public_deps = [ ":v8_snapshot" ]
-  } else {
-    assert(!v8_use_external_startup_data)
-    public_deps = [ ":v8_nosnapshot" ]
-  }
-}
-
 v8_source_set("v8_nosnapshot") {
   visibility = [ ":*" ]  # Only targets in this file can depend on this.
 
   deps = [
     ":js2c",
     ":js2c_experimental",
     ":js2c_experimental_extras",
     ":js2c_extras",
     ":v8_base",
   ]
@@ skipping 1339 matching lines @@
   visibility = [ ":*" ]  # Only targets in this file can depend on this.
 
   sources = [
     "test/fuzzer/fuzzer-support.cc",
     "test/fuzzer/fuzzer-support.h",
   ]
 
   configs = [ ":internal_config_base" ]
 
   deps = [
-    ":v8_maybe_snapshot",
+    snapshot_target,
   ]
 
   public_deps = [
     ":v8_libplatform",
   ]
 }
 
 ###############################################################################
 # Executables
 #
@@ skipping 21 matching lines @@
       "//build/config/sanitizers:deps",
       "//build/win:default_exe_manifest",
     ]
   }
 }
 
 ###############################################################################
 # Public targets
 #
 
-want_v8_shell = (
-    (current_toolchain == host_toolchain && v8_toolset_for_shell == "host") ||
-    (current_toolchain == v8_snapshot_toolchain &&
-     v8_toolset_for_shell == "host") ||
-    (current_toolchain != host_toolchain && v8_toolset_for_shell == "target"))
-
-group("gn_all") {
-  testonly = true
-
-  deps = [
-    ":d8",
-  ]
-
-  if (want_v8_shell) {
-    deps += [
-      ":v8_shell",
-    ]
-  }
-
-  if (host_os != "mac" || !is_android) {
-    # These items don't compile for Android on Mac.
-    deps += [
-      "test/unittests:unittests",
-    ]
-  }
-}
-
 if (is_component_build) {
   component("v8") {
     sources = [
       "src/v8dll-main.cc",
     ]
 
     public_deps = [
       ":v8_base",
-      ":v8_maybe_snapshot",
+      snapshot_target,
     ]
 
     configs -= [ "//build/config/compiler:chromium_code" ]
     configs += [ "//build/config/compiler:no_chromium_code" ]
     configs += [
       ":internal_config",
       ":features",
       ":toolchain",
     ]
 
     public_configs = [ ":external_config" ]
   }
 } else {
   group("v8") {
     public_deps = [
       ":v8_base",
-      ":v8_maybe_snapshot",
+      snapshot_target,
     ]
     public_configs = [ ":external_config" ]
   }
 }
 
 executable("d8") {
   sources = [
     "src/d8.cc",
     "src/d8.h",
   ]
@@ skipping 26 matching lines @@
   }
 
   if (!is_component_build) {
     sources += [ "$target_gen_dir/d8-js.cc" ]
   }
   if (v8_enable_i18n_support) {
     deps += [ "//third_party/icu" ]
   }
 }
 
-if (want_v8_shell) {
+if ((current_toolchain == host_toolchain && v8_toolset_for_shell == "host") ||
+    (current_toolchain == v8_snapshot_toolchain &&
+     v8_toolset_for_shell == "host") ||
+    (current_toolchain != host_toolchain && v8_toolset_for_shell == "target")) {
   executable("v8_shell") {
     sources = [
       "samples/shell.cc",
     ]
 
     configs -= [ "//build/config/compiler:chromium_code" ]
     configs += [ "//build/config/compiler:no_chromium_code" ]
     configs += [
       # Note: don't use :internal_config here because this target will get
       # the :external_config applied to it by virtue of depending on :v8, and
@@ skipping 68 matching lines @@
   sources = [
     "test/fuzzer/wasm-asmjs.cc",
   ]
 
   deps = [
     ":fuzzer_support",
   ]
 
   configs = [ ":internal_config" ]
 }