Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 2022893002: Revert of [gn] Add unittests (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [gn] Add unittests (patchset #6 id:100001 of https://codereview.chromium.org/2011853002/ ) Reason for revert: http://crbug.com/615890 Original issue's description: > [gn] Add unittests > > BUG=chromium:474921 > NOTRY=true > > Committed: https://crrev.com/67e549ec5b34ad02506abb2720c6a0851ae31f5e > Cr-Commit-Position: refs/heads/master@{#36510} > > Committed: https://crrev.com/143b3d167d7014525d049d3ab53c73cf2592243c > Cr-Commit-Position: refs/heads/master@{#36582} TBR=vogelheim@chromium.org,bmeurer@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:474921 Committed: https://crrev.com/b5249ff0679a9dd0ae35684a1831c68eac5f1665 Cr-Commit-Position: refs/heads/master@{#36605}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -223 lines) Patch
M BUILD.gn View 7 chunks +16 lines, -42 lines 0 comments Download
D build_overrides/gtest.gni View 1 chunk +0 lines, -15 lines 0 comments Download
D test/unittests/BUILD.gn View 1 chunk +0 lines, -166 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of [gn] Add unittests
4 years, 6 months ago (2016-05-31 06:23:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2022893002/1
4 years, 6 months ago (2016-05-31 06:23:33 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-31 06:23:47 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 06:24:55 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5249ff0679a9dd0ae35684a1831c68eac5f1665
Cr-Commit-Position: refs/heads/master@{#36605}

Powered by Google App Engine
This is Rietveld 408576698